Skip to content

[Stream Analytics] az stream-analytics input create: Fix authenticationMode being dropped for SQL reference inputs#9942

Merged
necusjz merged 2 commits into
Azure:mainfrom
huiii99:fix/sql-input-dropped-authentication-mode
Jun 17, 2026
Merged

[Stream Analytics] az stream-analytics input create: Fix authenticationMode being dropped for SQL reference inputs#9942
necusjz merged 2 commits into
Azure:mainfrom
huiii99:fix/sql-input-dropped-authentication-mode

Conversation

@huiii99

@huiii99 huiii99 commented Jun 16, 2026

Copy link
Copy Markdown
Member

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az stream-analytics input create

Description

This PR adds authentication_mode (mapped to properties.authenticationMode) to AzureSqlReferenceInputDataSource in both _models.py and _models_py3.py, so the value is now forwarded to the service. The extension version is bumped to 1.0.4 and a scenario test is added.

Fixes Azure/azure-cli#33553

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@huiii99 huiii99 requested a review from necusjz as a code owner June 16, 2026 04:10
Copilot AI review requested due to automatic review settings June 16, 2026 04:10
@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Jun 16, 2026

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes az stream-analytics input create dropping properties.authenticationMode for Azure SQL reference inputs by adding an authentication_mode field to the vendored AzureSqlReferenceInputDataSource model so it serializes to properties.authenticationMode correctly.

Changes:

  • Add authentication_mode mapping to AzureSqlReferenceInputDataSource in both _models.py and _models_py3.py.
  • Bump the stream-analytics extension version to 1.0.4 and add a corresponding HISTORY.rst entry.
  • Add a scenario test (+ recording) validating authenticationMode round-trips on create/show for SQL reference inputs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/stream-analytics/setup.py Bumps extension version to 1.0.4.
src/stream-analytics/HISTORY.rst Adds 1.0.4 release note entry.
src/stream-analytics/azext_stream_analytics/vendored_sdks/streamanalytics/models/_models.py Adds authentication_mode attribute mapping for SQL reference input datasource (py2-style model).
src/stream-analytics/azext_stream_analytics/vendored_sdks/streamanalytics/models/_models_py3.py Adds authentication_mode attribute mapping + typing for SQL reference input datasource (py3 model).
src/stream-analytics/azext_stream_analytics/tests/latest/test_stream_analytics_commands.py Adds scenario test covering SQL reference input authenticationMode.
src/stream-analytics/azext_stream_analytics/tests/latest/recordings/test_input_sql_reference_authentication_mode.yaml Adds recording for the new scenario test.

Comment thread src/stream-analytics/HISTORY.rst
@yonzhan

yonzhan commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Stream Analytics

@necusjz necusjz merged commit 2a58338 into Azure:main Jun 17, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ stream-analytics-1.0.4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=168360434&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying Azure Stram Analytics(ASA) SQL Input using CLI will not trigger the policy

5 participants