Skip to content

QCrypton PQC Scanner for Microsoft Sentinel - #15114

Merged
v-atulyadav merged 1 commit into
Azure:masterfrom
gunjanmj:feature/qcrypton-pqc-scanner
Oct 23, 2026
Merged

v-atulyadav merged 1 commit into
Azure:masterfrom
gunjanmj:feature/qcrypton-pqc-scanner

Conversation

@gunjanmj

@gunjanmj Gunjan Jain (gunjanmj) commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Change(s):

  • Added QCrypton PQC (Post-Quantum Cryptography) Scanner solution for Microsoft Sentinel
  • Added QCrypton logo (Logos/qcrypton.svg)
  • Added 6 Analytic Rules: AppServiceLegacyTLS, CertExpiresAfter2030Classical, NewQuantumVulnerableResource,
    QuantumVulnerableKVKey, QuantumVulnerableEntraCert, WeakTLSCertOnGateway
  • Added Data Connector for QCryptonPQCScanner
  • Added QCryptonPQReadiness Workbook
  • Added QCryptonPQC-Notify Playbook
  • Added Solution package (mainTemplate.json, createUiDefinition.json)
  • Added SolutionMetadata.json and ReleaseNotes.md

Reason for Change(s):

New solution submission — QCrypton PQC Scanner helps organizations identify quantum-vulnerable
cryptographic assets (certificates, keys, TLS configurations) in their Azure environment to prepare
for post-quantum cryptography migration.

Version Updated:

Yes — initial version 3.0.0

Testing Completed:

Yes — tested in a Microsoft Sentinel environment with no custom parsers, functions, or tables. All
analytic rules, data connector, workbook, and playbook validated successfully.

Checked that the validations are passing and have addressed any issues that are present:

Yes

@gunjanmj

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="QCrypton, Inc"

@v-atulyadav
v-atulyadav requested a lite review from Copilot September 14, 2026 04:09
@v-atulyadav v-atulyadav added the New Solution For new Solutions which are new to Microsoft Sentinel label Sep 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Pull request overview

Introduces the QCrypton PQC Scanner Microsoft Sentinel solution package, including a data connector, analytic rules, workbook, and Teams-notification playbook for tracking post-quantum cryptography readiness.

Changes:

  • Added workbook, data connector, and 5 scheduled analytic rule templates targeting quantum-vulnerable assets.
  • Added a Teams notification playbook (Logic App) and solution packaging artifacts (ARM template + UI definition).
  • Added solution metadata + release notes.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
Solutions/QCryptonPQCScanner/Workbooks/QCryptonPQReadiness.json Adds PQ readiness workbook with parameterized KQL visualizations.
Solutions/QCryptonPQCScanner/SolutionMetadata.json Adds publisher/offer metadata and support contact details.
Solutions/QCryptonPQCScanner/ReleaseNotes.md Adds initial release notes entry for the solution.
Solutions/QCryptonPQCScanner/Playbooks/QCryptonPQC-Notify/azuredeploy.json Adds Logic App playbook template to post incidents to Teams.
Solutions/QCryptonPQCScanner/Package/testParameters.json Adds ARM test parameters used for packaging/validation.
Solutions/QCryptonPQCScanner/Package/mainTemplate.json Adds the solution’s main ARM template packaging connector/rules/workbook/playbook.
Solutions/QCryptonPQCScanner/Package/createUiDefinition.json Adds install-time UI for selecting the Log Analytics workspace.
Solutions/QCryptonPQCScanner/Data/QCryptonPQCScanner.json Adds solution manifest referencing included artifacts and version.
Solutions/QCryptonPQCScanner/Data Connectors/QCryptonPQCScanner.json Adds Customizable data connector definition for PQReadiness_CL.
Solutions/QCryptonPQCScanner/Analytic Rules/*.yaml Adds 5 analytic rule templates for vulnerable PQ posture detections.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Solutions/QCryptonPQCScanner/Package/mainTemplate.json
Comment thread Solutions/QCryptonPQCScanner/Package/createUiDefinition.json
Comment thread Solutions/QCryptonPQCScanner/Package/mainTemplate.json Outdated
Comment thread Solutions/QCryptonPQCScanner/ReleaseNotes.md Outdated
Comment thread Solutions/QCryptonPQCScanner/ReleaseNotes.md Outdated
@gunjanmj
Gunjan Jain (gunjanmj) requested a review from a team as a code owner September 14, 2026 17:44
@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch 2 times, most recently from 510de11 to dcd5d56 Compare September 15, 2026 00:45
@v-skharode

Copy link
Copy Markdown
Contributor

We are putting your PR on hold because your solution is not Sentinel Codeless Connector Framework (CCF). We would be happy to work with you to migrate your solution to CCF. Please contact the Microsoft Sentinel Partners at AzureSentinelPartner@microsoft.com to discuss available options.

@v-skharode

Copy link
Copy Markdown
Contributor

Follow-up:
We are awaiting your response to the review feedback shared earlier. Please provide an update on the requested changes and let us know once they have been addressed so we can continue the review process.

@gunjanmj

Gunjan Jain (gunjanmj) commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Hello v-skharode thankyou for the feedback. working on the pull-based CCF-based solution. will update soon!

@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-skharode Could you please review the changes again? I have replaced push-based to pull-based CCF Solution.

@v-skharode

Copy link
Copy Markdown
Contributor

Kindly add both black-and-white preview images to the workbook preview images folder and also add the images/logo under the Workbooks/Images/Preview path. Additionally, please also add the required README.md under QCryptonPQC-Notify, package the solution with version 3.0.0, and update the release notes accordingly.
Please regenerate the package after correcting the stale QCryptonPQC solution and logo references. Also provide the required Function App exception/approval evidence and deployment, invocation, and ingestion test results.

@gunjanmj
Gunjan Jain (gunjanmj) requested a review from a team as a code owner September 17, 2026 18:32
@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch 4 times, most recently from 3f0e17f to 4133507 Compare September 17, 2026 23:53
@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-skharode Addressed review comments in new commit. Could you please review the changes again? Thanks!

@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch 2 times, most recently from 68b3d6a to a5aa591 Compare September 18, 2026 23:32
@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-skharode Could you please let me know updates on this PR?

@gunjanmj

Gunjan Jain (gunjanmj) commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Gunjan Jain (Gunjan Jain (@gunjanmj)) Could you please share screenshots showing the connector in a running/connected state along with the corresponding ingestion/log evidence for validation?

v-skharode I do not have the connector in running/connected state.
02-data-connector
07-logs-schema
03-active-rules

v-skharode v-atulyadav any updates on this PR?

@v-skharode

Copy link
Copy Markdown
Contributor

Gunjan Jain (@gunjanmj) Thanks for sharing the screenshots. The connector currently shows Disconnected, and the schema/analytics screenshots do not yet confirm successful data ingestion. Could you please share:

  • A screenshot showing the connector in a Connected state
  • Recent ingested records from PQCReadiness_CL with timestamps
  • Confirmation that the package version mismatch has been resolved
  • Confirmation that the empty ApiKeyIdentifier validation finding has been addressed and ARM-TTK passes after regeneration

These validations are still required before the review can be completed.

@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch from 9b4d818 to 1b5b3be Compare October 6, 2026 13:31
@gunjanmj

Copy link
Copy Markdown
Contributor Author
  • package version

v-skharode Attached are the screenshots.
connected_status
ingested_records
KQL_results_with_timestamps
package version
empty ApiKeyIdentifier validation finding

Note: IDs Should Be Derived From ResourceIDs filtered out in CI pipeline.

@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch from ced560e to 7cf3a98 Compare October 6, 2026 15:39
@v-skharode

Copy link
Copy Markdown
Contributor

Hi Gunjan Jain (@gunjanmj)
Thanks for the evidence. ARM-TTK reports 49/50 passed. Could you confirm the failed test is the documented ID check exception and that the ApiKeyIdentifier finding is resolved?

@gunjanmj

Copy link
Copy Markdown
Contributor Author

Hi Gunjan Jain (Gunjan Jain (@gunjanmj)) Thanks for the evidence. ARM-TTK reports 49/50 passed. Could you confirm the failed test is the documented ID check exception and that the ApiKeyIdentifier finding is resolved?

Screenshot 2026-10-06 at 10 51 50 PM Screenshot 2026-10-06 at 10 52 45 PM

@v-skharode

Copy link
Copy Markdown
Contributor

hi again Gunjan Jain (@gunjanmj)
Thanks for sharing the updated ARM-TTK results. The remaining failure appears to match the documented ID-based exception. Could you share the filtered CI/wrapper result and confirm it was run against commit 7cf3a98 and package 3.0.0?

I verified that the package uses ApiKey/ApiKeyName and does not contain ApiKeyIdentifier, so that concern is resolved.

I still see the Entra certificate rule missing from the solution manifest, a Release Notes header mismatch, playbook metadata/authentication issues, and blank workbook preview images. Please address these items before approval.

@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch from 7cf3a98 to 7985b8d Compare October 7, 2026 07:07
@gunjanmj

Copy link
Copy Markdown
Contributor Author

hi again Gunjan Jain (Gunjan Jain (@gunjanmj)) Thanks for sharing the updated ARM-TTK results. The remaining failure appears to match the documented ID-based exception. Could you share the filtered CI/wrapper result and confirm it was run against commit 7cf3a98 and package 3.0.0?

I verified that the package uses ApiKey/ApiKeyName and does not contain ApiKeyIdentifier, so that concern is resolved.

I still see the Entra certificate rule missing from the solution manifest, a Release Notes header mismatch, playbook metadata/authentication issues, and blank workbook preview images. Please address these items before approval.

Screenshot 2026-10-07 at 12 10 23 AM Content hub Screenshot 2026-10-07 at 1 17 09 AM Screenshot 2026-10-07 at 1 18 08 AM

@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-atulyadav v-skharode any updates on this PR? by when can this be merged?

@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-skharode v-atulyadav please approve the PR before you try to merge it. the pipeline will succeed.

@v-skharode

Copy link
Copy Markdown
Contributor

Will run a final re-review for this PR before the approval.

@v-skharode

Copy link
Copy Markdown
Contributor

Hey Gunjan Jain (@gunjanmj)
Everything else looks good, and the PR looks ready for approval once these two points are addressed:

  • The source contains six analytic rules, but the deployment sandbox shows only five. Please regenerate the package and confirm all six appear under Analytics.
  • The logo is not loading in the sandbox. Please verify the logo URL.

@gunjanmj

Gunjan Jain (gunjanmj) commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Hey Gunjan Jain (Gunjan Jain (@gunjanmj)) Everything else looks good, and the PR looks ready for approval once these two points are addressed:

  • The source contains six analytic rules, but the deployment sandbox shows only five. Please regenerate the package and confirm all six appear under Analytics.
  • The logo is not loading in the sandbox. Please verify the logo URL.

v-skharode the logo url will load after merge in master branch. please re- review. thanks!

@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch 2 times, most recently from 9341cad to 4e1bd6d Compare October 21, 2026 14:27
@v-skharode

Copy link
Copy Markdown
Contributor

Thanks for the updates. Please address these two remaining points before approval:

  • The logo is approximately 124 KB, exceeding the repository’s 5 KB limit. Please replace it with an optimized SVG; merging will resolve URL availability, but not the size issue.
  • All six analytic rules are missing the required status field. Please add status: Available if they are production-ready.

Gunjan Jain (gunjanmj) added a commit to gunjanmj/Azure-Sentinel that referenced this pull request Oct 22, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch from 4e1bd6d to c4f7eaf Compare October 22, 2026 11:01
@gunjanmj
Gunjan Jain (gunjanmj) force-pushed the feature/qcrypton-pqc-scanner branch from c4f7eaf to b871f94 Compare October 22, 2026 11:03
@github-actions github-actions Bot added ISV Solution 3P / ISV Partner-authored or Partner-integrated Sentinel solution Solution Solution specialty review needed labels Oct 22, 2026
@v-skharode

Copy link
Copy Markdown
Contributor

Hey Gunjan Jain (@gunjanmj)
Thanks for addressing the feedback, Approving the PR. Please just also wire TeamsGroupId and TeamsChannelId into the workflow parameters, or substitute them using ARM expressions, so the Teams action can resolve these values. Thanks!!

@v-atulyadav
v-atulyadav merged commit 9611f50 into Azure:master Oct 23, 2026
39 checks passed
@gunjanmj

Copy link
Copy Markdown
Contributor Author

v-skharode v-atulyadav Thank you for merging the PR. QCrypton's solution integrates with Sentinel, Entra ID, and Defender. We meet all three MISA membership requirements — could you nominate QCrypton for MISA, or connect me with the right Program manager to initiate the nomination? Looking forward to continuing to build on this partnership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ISV Solution 3P / ISV Partner-authored or Partner-integrated Sentinel solution New Solution For new Solutions which are new to Microsoft Sentinel Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants