Repository navigation
QCrypton PQC Scanner for Microsoft Sentinel - #15114
Conversation
2de5040 to
21a4ade
Compare
|
@microsoft-github-policy-service agree company="QCrypton, Inc" |
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Pull request overview
Introduces the QCrypton PQC Scanner Microsoft Sentinel solution package, including a data connector, analytic rules, workbook, and Teams-notification playbook for tracking post-quantum cryptography readiness.
Changes:
- Added workbook, data connector, and 5 scheduled analytic rule templates targeting quantum-vulnerable assets.
- Added a Teams notification playbook (Logic App) and solution packaging artifacts (ARM template + UI definition).
- Added solution metadata + release notes.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/QCryptonPQCScanner/Workbooks/QCryptonPQReadiness.json | Adds PQ readiness workbook with parameterized KQL visualizations. |
| Solutions/QCryptonPQCScanner/SolutionMetadata.json | Adds publisher/offer metadata and support contact details. |
| Solutions/QCryptonPQCScanner/ReleaseNotes.md | Adds initial release notes entry for the solution. |
| Solutions/QCryptonPQCScanner/Playbooks/QCryptonPQC-Notify/azuredeploy.json | Adds Logic App playbook template to post incidents to Teams. |
| Solutions/QCryptonPQCScanner/Package/testParameters.json | Adds ARM test parameters used for packaging/validation. |
| Solutions/QCryptonPQCScanner/Package/mainTemplate.json | Adds the solution’s main ARM template packaging connector/rules/workbook/playbook. |
| Solutions/QCryptonPQCScanner/Package/createUiDefinition.json | Adds install-time UI for selecting the Log Analytics workspace. |
| Solutions/QCryptonPQCScanner/Data/QCryptonPQCScanner.json | Adds solution manifest referencing included artifacts and version. |
| Solutions/QCryptonPQCScanner/Data Connectors/QCryptonPQCScanner.json | Adds Customizable data connector definition for PQReadiness_CL. |
| Solutions/QCryptonPQCScanner/Analytic Rules/*.yaml | Adds 5 analytic rule templates for vulnerable PQ posture detections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
21a4ade to
666233a
Compare
510de11 to
dcd5d56
Compare
|
We are putting your PR on hold because your solution is not Sentinel Codeless Connector Framework (CCF). We would be happy to work with you to migrate your solution to CCF. Please contact the Microsoft Sentinel Partners at AzureSentinelPartner@microsoft.com to discuss available options. |
|
Follow-up: |
|
Hello v-skharode thankyou for the feedback. working on the pull-based CCF-based solution. will update soon! |
dcd5d56 to
6e811cf
Compare
|
v-skharode Could you please review the changes again? I have replaced push-based to pull-based CCF Solution. |
6e811cf to
45f8dcf
Compare
|
Kindly add both black-and-white preview images to the workbook preview images folder and also add the images/logo under the Workbooks/Images/Preview path. Additionally, please also add the required README.md under QCryptonPQC-Notify, package the solution with version 3.0.0, and update the release notes accordingly. |
16de95f to
f35f6e9
Compare
3f0e17f to
4133507
Compare
|
v-skharode Addressed review comments in new commit. Could you please review the changes again? Thanks! |
68b3d6a to
a5aa591
Compare
|
v-skharode Could you please let me know updates on this PR? |
v-skharode I do not have the connector in running/connected state. v-skharode v-atulyadav any updates on this PR? |
|
Gunjan Jain (@gunjanmj) Thanks for sharing the screenshots. The connector currently shows Disconnected, and the schema/analytics screenshots do not yet confirm successful data ingestion. Could you please share:
These validations are still required before the review can be completed. |
9b4d818 to
1b5b3be
Compare
v-skharode Attached are the screenshots. Note: IDs Should Be Derived From ResourceIDs filtered out in CI pipeline. |
ced560e to
7cf3a98
Compare
|
Hi Gunjan Jain (@gunjanmj) |
|
|
hi again Gunjan Jain (@gunjanmj) I verified that the package uses ApiKey/ApiKeyName and does not contain ApiKeyIdentifier, so that concern is resolved. I still see the Entra certificate rule missing from the solution manifest, a Release Notes header mismatch, playbook metadata/authentication issues, and blank workbook preview images. Please address these items before approval. |
7cf3a98 to
7985b8d
Compare
|
|
v-atulyadav v-skharode any updates on this PR? by when can this be merged? |
|
v-skharode v-atulyadav please approve the PR before you try to merge it. the pipeline will succeed. |
|
Will run a final re-review for this PR before the approval. |
|
Hey Gunjan Jain (@gunjanmj)
|
v-skharode the logo url will load after merge in master branch. please re- review. thanks! |
9341cad to
4e1bd6d
Compare
|
Thanks for the updates. Please address these two remaining points before approval:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4e1bd6d to
c4f7eaf
Compare
c4f7eaf to
b871f94
Compare
|
Hey Gunjan Jain (@gunjanmj) |
|
v-skharode v-atulyadav Thank you for merging the PR. QCrypton's solution integrates with Sentinel, Entra ID, and Defender. We meet all three MISA membership requirements — could you nominate QCrypton for MISA, or connect me with the right Program manager to initiate the nomination? Looking forward to continuing to build on this partnership. |














Change(s):
QuantumVulnerableKVKey, QuantumVulnerableEntraCert, WeakTLSCertOnGateway
Reason for Change(s):
New solution submission — QCrypton PQC Scanner helps organizations identify quantum-vulnerable
cryptographic assets (certificates, keys, TLS configurations) in their Azure environment to prepare
for post-quantum cryptography migration.
Version Updated:
Yes — initial version 3.0.0
Testing Completed:
Yes — tested in a Microsoft Sentinel environment with no custom parsers, functions, or tables. All
analytic rules, data connector, workbook, and playbook validated successfully.
Checked that the validations are passing and have addressed any issues that are present:
Yes