Optimization for concurrent Key Vault Ref resolution - deduplicate requests to the same secret#328
Open
linglingye001 wants to merge 1 commit into
Open
Optimization for concurrent Key Vault Ref resolution - deduplicate requests to the same secret#328linglingye001 wants to merge 1 commit into
linglingye001 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds in-flight request deduplication to Key Vault secret resolution so that concurrent configuration settings referencing the same secret URI don’t trigger redundant Key Vault (or resolver) calls.
Changes:
- Added an in-flight promise map in
AzureKeyVaultSecretProvider.getSecretValue()to deduplicate concurrent secret fetches by secret identifier. - Added test coverage validating deduplication in parallel and sequential modes, secret-version independence, failure behavior, and refresh behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/keyvault/keyVaultSecretProvider.ts |
Introduces in-flight request deduplication for identical secret identifiers and ensures in-flight entries are cleared after completion. |
test/keyvault.test.ts |
Adds a new test suite covering request deduplication behavior across parallel/sequential resolution, versions, failures, and refresh rounds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+295
to
+296
| await sleepInMs(60_000 + 100); | ||
| await settings.refresh(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.