[claim-check] Update Sample 4 and 2 - #570
Conversation
There was a problem hiding this comment.
Pull request overview
Updates claim-check samples 2 and 4 to newer .NET and dependency versions.
Changes:
- Migrates Sample 2 to .NET 10.
- Updates NuGet dependencies.
- Corrects Sample 4’s local Functions launch command.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
sample-4/readme.md |
Documents launching with dotnet run. |
FunctionConsumer4.csproj |
Updates Azure Functions dependencies. |
ClientProducer4.csproj |
Updates producer dependencies. |
sample-2/readme.md |
Documents the .NET 10 migration. |
ClientConsumer2.csproj |
Targets .NET 10 and updates dependencies. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
5ab75e0 to
5853478
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
claim-check/code-samples/sample-2/readme.md:34
- The project now targets
net10.0, but this prerequisite still tells users to install the .NET 9 SDK while linking to .NET 10. Following the label can leave them unable to build the sample; change it to .NET 10 SDK.
- [.NET 9 SDK](https://dotnet.microsoft.com/download/dotnet/10.0)
claim-check/code-samples/sample-2/readme.md:7
- Unresolved merge-conflict markers are rendered as README content and leave two competing technology headings. Resolve the conflict and keep the plural “Event Hubs,” which matches the sample title and the service name used below.
<<<<<<< HEAD
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hubs, .NET 10.0
=======
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
>>>>>>> 5ab75e0 (Net10)
claim-check/code-samples/sample-4/readme.md:88
- Remove the duplicated word in “to the the screen.”
> Please note: For demo purposes, the sample application will write the payload content to the the screen. Keep that in mind before you try sending really large payloads.
5853478 to
a978f8f
Compare
a978f8f to
a59cae0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (4)
claim-check/code-samples/sample-2/readme.md:30
- This sample targets
net10.0, the heading specifies .NET 10.0, and the link already points to the .NET 10 download. Listing the .NET 9 SDK gives users the wrong build prerequisite.
- [.NET 10 SDK](https://dotnet.microsoft.com/download/dotnet/10.0)
claim-check/code-samples/sample-4/readme.md:86
- The linked guide says Worker SDK 2.0.0 adds support for
dotnet run; it does not replacefunc startor state that extensions require it. Microsoft’s local-development guide still documentsfunc startfor isolated workers, so this rationale is misleading. Reword it as sample-specific support rather than a requirement.
> This project uses the [.NET isolated worker model](https://learn.microsoft.com/azure/azure-functions/dotnet-isolated-process-guide). Starting with `Microsoft.Azure.Functions.Worker.Sdk` 2.0.0, use `dotnet run` instead of `func start` to ensure function extensions are loaded correctly from the build output directory.
claim-check/code-samples/sample-4/readme.md:88
- Remove the duplicated “the”.
> Please note: For demo purposes, the sample application will write the payload content to the the screen. Keep that in mind before you try sending really large payloads.
claim-check/code-samples/sample-2/readme.md:3
- Use the product’s official plural name, “Azure Event Hubs,” consistently with the title and surrounding text.
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
claim-check/code-samples/sample-4/readme.md:88
- Remove the duplicated “the” from this sentence.
> Please note: For demo purposes, the sample application will write the payload content to the the screen. Keep that in mind before you try sending really large payloads.
claim-check/code-samples/sample-4/readme.md:86
- The linked guide only says Worker SDK 2.0 adds support for
dotnet run; it does not replacefunc start, and the current Core Tools documentation still prescribesfunc startfor isolated-worker projects. Rephrase this as an optional supported command rather than claiming it is required for extension loading.
> This project uses the [.NET isolated worker model](https://learn.microsoft.com/azure/azure-functions/dotnet-isolated-process-guide). Starting with `Microsoft.Azure.Functions.Worker.Sdk` 2.0.0, use `dotnet run` instead of `func start` to ensure function extensions are loaded correctly from the build output directory.
claim-check/code-samples/sample-2/readme.md:3
- This changes the official product name to the singular form, while the title and surrounding text correctly identify the service as Azure Event Hubs. Keep the product name consistent here.
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
claim-check/code-samples/sample-2/readme.md:3
- Use the official service name “Azure Event Hubs” here. The singular form is inconsistent with this README’s title and description and refers to an individual Event Hub rather than the Azure service.
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
claim-check/code-samples/sample-2/readme.md:3
- Use the official service name “Azure Event Hubs” here. “Event Hub” refers to an individual hub, while this list names Azure services; the title and the linked service name on line 5 also use “Event Hubs.”
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (3)
claim-check/code-samples/sample-2/ClientConsumer2/ClientConsumer2.csproj:30
- This project targets
net10.0, which already providesSystem.Text.RegularExpressions; this direct reference is prunable and produces NU1510. The package assembly is not selected over the SDK-bundled assembly, so remove the reference rather than pinning 4.3.1.
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
claim-check/code-samples/sample-2/readme.md:3
- The Azure service's product name is “Azure Event Hubs,” as used in this page's title and body; changing it to the singular makes this technology list inaccurate.
## Technologies used: Azure Blob Storage, Azure Event Grid, Azure Event Hub, .NET 10.0
claim-check/code-samples/sample-4/ClientProducer4/ClientProducer4.csproj:29
- This project targets
net10.0, which already providesSystem.Text.RegularExpressions; this direct reference is prunable and produces NU1510. The package assembly is not selected over the SDK-bundled assembly, so remove the reference rather than pinning 4.3.1.
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
#566
#565
#563