ci: default the test workflows' token to contents: read - #44
Open
alejoamiras wants to merge 1 commit into
Open
alejoamiras wants to merge 1 commit into
alejoamiras wants to merge 1 commit into
Conversation
pr-checks.yml and main-tests.yml set no permissions, so every job without its own block (format, and the run-tests.yml calls) got the repository's default token. That default is read-only today, but nothing in the workflows pins it. A workflow-level `contents: read` covers those jobs; `changes` and `benchmark` keep their own blocks. Resolves CodeQL actions/missing-workflow-permissions alerts #2, #3, #4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: multitoken
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-checks.ymlandmain-tests.ymldidn't setpermissions, soformatand therun-tests.ymlcalls got the repo's default token. That's read-only today, but nothing pinned it - if the setting ever changed, those jobs would get write access while running third-party actions andyarn install.Adds
permissions: contents: readat the workflow level;changesandbenchmarkkeep their own blocks. Closes CodeQL alerts #2, #3 and #4. #38 fixes the same thing on the JS jobs it adds, and the two merge cleanly in either order.🤖 Generated with Claude Code