test(e2e): assert no equivocation offenses in HA full test#23496
Merged
spalladino merged 1 commit intoMay 22, 2026
Conversation
The P2P attestation pool is not a durable record of past-slot attestations under pipelining: the validator rejects late arrivals and the pool prunes on finalization. Replace the racy pool-content assertion with a query of the gossip-detected DUPLICATE_ATTESTATION/DUPLICATE_PROPOSAL offenses tracked by each node's slasher, which is the canonical signal that the HA slashing protection failed. Also flag the test as a flake on its specific failure regex.
spalladino
force-pushed
the
spl/fix-ha-full-equivocation-check
branch
from
53b7caf to
035ac6a
Compare
PhilWindle
approved these changes
May 22, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spypsy
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The HA full test failed in CI (20d38a958c951a40) on
expect(p2pAttestationsWithSignatures.length).toBeGreaterThan(0). The P2P attestation pool is not a durable record of past-slot attestations under pipelining: the validator rejects late arrivals (slot not in current/next or pipelining window) and the pool prunes viadeleteOlderThanon every finalization. By the time the test loop reaches the assertion, attestations for earlier slots have either been rejected or pruned.Approach
Replace the pool-content assertion with a query of the gossip-detected equivocation offenses tracked by each node's slasher. The pipeline is
libp2p_service::duplicateAttestationCallback→validator-client::handleDuplicateAttestation→WANT_TO_SLASH_EVENT→SlashOffensesCollector→ offenses store →node.getSlashOffenses('all'). The last-surviving HA node observed every gossiped attestation, so a single query covers all slots. This matches the pattern inepochs_equivocation.test.ts.Changes
DUPLICATE_ATTESTATIONorDUPLICATE_PROPOSALoffense was collected by any active HA node.