Repository navigation
typescript: a class in one program is not a structural implementor of another program's global - #1779
Merged
Merged
Conversation
… another program's global A client global belongs to one program (#1574 scoped name lookup and merging), but structural satisfaction still paired every same-shaped class with it. A production class with a `map` became an implementor of a test fixture's hand-written `interface Array`, so fixture `xs.map(cb)` dispatched into production code and production `this.items.map(f)` dispatched into fixture classes; callback reach then crossed every program in the repository. A structural pair is dropped when the target is a client global and neither program sees the other's file (same governed-by / under-directory test as program_sees). Root globals keep nested conformers; same-program pairs and modules with no tsconfig are untouched. Golden case 82 (sibling programs) with a control: the fixture's own Bag keeps its dispatch from rows.map. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com> Co-Authored-By: Claude <noreply@anthropic.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
September 29, 2026 05:59
Contributor
Author
|
Verified on this repo after rebase (TS graph, branch engine vs 0.1.9 engine):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class in one TypeScript program was still counted as a structural implementor of a global declared in another program: a production class with
map"implemented" a test fixture's hand-writteninterface Array. Fixturexs.map(cb)then dispatched into production code, and productionthis.items.map(f)dispatched into fixture classes. Callback reach went across every program in the repo.program_seesuses). Root globals keep nested conformers, and same-program pairs are unchanged.Bagkeeps its dispatch fromrows.map.Closes #1574