Repository navigation
fix(erc-8350): sync editor revision and complete conformance inputs - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Synchronize the Office Hour #113 editor revision for ethereum/ERCs#1910 into the product's ERC mirror and strengthen v1 conformance coverage.
Verification
Source:
2982461374d84b37215c95bbc36c0e61ea8d61efpnpm conformance:cleanfrom a clean detached checkout using Node 22.23.2, pnpm 11.7.0, Foundry 1.7.1 and Solidity 0.8.24.test-vectors/v1.jsonbyte-for-byte; the Solidity suite also runs against the submitted asset.5e04cb9c1181222f483d3ad547e0a9aa301dfab74c7028f3cfa2e5dcd574fc20.Boundaries
No protocol hash algorithm or state-machine behavior is changed. Frozen G4 evidence is preserved and does not constitute an audit of this revision. No deployment is changed. Local results do not imply GitHub CI approval or Editor approval. Dependency audit is not included in the local conformance claim.
Revision mapping and reproduction instructions:
docs/reviews/office-hour-113.md.