Skip to content

Fix/tooltip typo and status chip test #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aramani-availity wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/tooltip typo and status chip test #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86bb484
fix(mui-chip): fix StatusChip test importing wrong component
aramani-availity Jul 17, 2026
ebb8b25
fix(mui-tooltip): fix typo in leaveDelay description (micro seconds →…
aramani-availity Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/chip/src/lib/StatusChip.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { render } from '@testing-library/react';
import { Chip } from './Chip';
import { StatusChip } from './StatusChip';

describe('Chip', () => {
describe('StatusChip', () => {

@LauRoxx LauRoxx Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to make changes, but as a general note for the future - since these changes are for only tests and docs then a new version is not needed.

if you were instead to name the commits test(mui-chip): fix StatusChip test importing wrong component and docs(mui-tooltip): fix typo in leaveDelay description (micro seconds → milliseconds) then semver would skip those commits when determining version.

@LauRoxx LauRoxx Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, quick correction. we skip docs commits, but not test. so test would still trigger a new version.

test('should render successfully', () => {
const { getByText } = render(<Chip label="Test" />);
const { getByText } = render(<StatusChip label="Test" />);
expect(getByText('Test')).toBeTruthy();
});
});
2 changes: 1 addition & 1 deletion packages/tooltip/src/lib/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const argTypes = {
},
},
leaveDelay: {
description: 'Delay before the tooltip is hidden. (micro seconds)',
description: 'Delay before the tooltip is hidden. (milliseconds)',
control: { type: 'number' },
table: { type: { summary: 'number' } },
defaultValue: { summary: 0 },
Expand Down
Loading