chore: upgrade to eslint-config-availity v16 and TypeScript 6 - #1750
Open
jordan-a-young wants to merge 3 commits into
Open
jordan-a-young wants to merge 3 commits into
jordan-a-young wants to merge 3 commits into
Conversation
- Bump eslint-config-availity ^14.0.0 → ^16.0.0 - Add @vitest/eslint-plugin ^1.0.0 (required peer dep in v16) - Upgrade typescript 5.9.3 → 6.x (resolves to 6.0.3) - Run ts5to6 --fixBaseUrl: remove baseUrl from root tsconfig, relativize paths - Run ts5to6 --fixRootDir: add rootDir:../.. to packages/form (has allowJs:true) - Update eslint.config.js: add withVitest test-runner config, remove vi global shim and stale jest/* rules - Fix 13 new unicorn lint errors: keyCode→key in change-password/feedback, no-this-outside-of-class in feedback (yup.addMethod), no-immediate-mutation in spaces
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
September 15, 2026 19:57
TypeScript 6 DTS build via tsup raised two errors: - TS5101: paths without baseUrl triggers deprecation warning even with moduleResolution:bundler — silenced with ignoreDeprecations:6.0 - TS2882: noUncheckedSideEffectImports now defaults to true in strict mode, breaking CSS side-effect imports across block-ui, change-password, form-upload, page-header, spaces, upload — disabled at root
Replace > -1 with !== -1 (unicorn/consistent-existence-index-check). Also remove stale eslint-disable comment for a rule that no longer fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the monorepo to use
eslint-config-availityv16 and TypeScript 6.0.3.Changes
Dependencies
eslint-config-availity^14.0.0→^16.0.0@vitest/eslint-plugin^1.0.0added (required peer dep in v16)typescript5.9.3→6.x(resolves to 6.0.3)TypeScript 6 migration
tsconfig.json: Rants5to6 --fixBaseUrl— removed deprecatedbaseUrl: "."and converted all 39pathsmappings to relative (./) prefixes.moduleResolution: bundlercontinues to resolve correctly.packages/form/tsconfig.json:ts5to6 --fixRootDiraddedrootDir: "../.."" (this package usesallowJs: true`, which required the fix).yarn typecheckpasses cleanly with TS 6.0.3.ESLint config
eslint.config.js: Removed manualvi: 'readonly'global shim and stalejest/no-*rules. AddedwithVitestfromeslint-config-availity/test-runnersso Vitest globals are handled by the plugin.Lint fixes (13 new unicorn errors introduced by v16 ruleset)
change-password/src/ChangePasswordForm.jsxkeyCode→key(3 handlers)feedback/src/FeedbackButton.jsxkeyCode→keyfeedback/src/SmileField.jsxkeyCode→key(2 references)feedback/src/FeedbackForm.jsxeslint-disable-next-lineforno-this-outside-of-classinyup.addMethodcallbackfeedback/src/SupportForm.jsxkeyCode→keyspaces/src/Spaces.jsxrequestBody.operationNameassignment into object literalTesting
yarn lint— ✅ all 40 projects pass (0 errors)yarn test— ✅ all 39 test-bearing projects passyarn typecheck— ✅ passes under TypeScript 6.0.3Notes
typescriptas a peer dependency, so step 7 (update peerDeps) was a no-op.noUncheckedSideEffectImportserrors appeared for CSS imports — no tsconfig changes needed there.