fix: clean up console warnings in table, date, and phone - #1748
Merged
jordan-a-young merged 5 commits intoSep 15, 2026
Merged
Conversation
- Extract `key` from react-table prop spreads in TableHeaderRow, TableHeaderCell, TableRow, and TableCell to satisfy React 19's requirement that keys be passed directly rather than via spread - Resolve 'Functions are not valid as a React child' in BulkTableActions by calling displayText when it is a function instead of rendering it directly; update snapshot accordingly - Wrap bare fireEvent.click/change/blur calls that trigger async Formik and react-dates state updates in `act()` across DateField, DateRange, DateRangeField, and Phone tests to silence act() warnings
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
September 14, 2026 21:38
- Move Nx cache restore before yarn install in all jobs - Add NX_DAEMON=false to prevent daemon fork attempts in CI - Upload build artifacts in setup job, download in downstream jobs to avoid redundant rebuilds across publish and deploy-docs - Parallelize deploy-docs with publish by depending on setup instead of waiting for publish to complete
Only breaking change in jsdom 30 is Node.js minimum raised to ^22.22.2 || ^24.15.0 || >=26.0.0, which is satisfied by CI matrix. All 381/974/729 tests passing.
- actions/upload-artifact: v4 (floating) -> v7.0.1 (SHA pinned) - actions/download-artifact: v4 (floating) -> v8.0.1 (SHA pinned) - actions/upload-pages-artifact: v3.0.1 -> v5.0.0 - actions/deploy-pages: v4.0.5 -> v5.0.1 All updated versions run on Node.js 24, eliminating the Node.js 20 deprecation warnings seen in CI. Also pins floating @v4 tags to exact SHAs for consistency with the rest of the workflow files.
jordan-a-young
deleted the
fix/console-warnings-key-prop-act-displaytext
branch
September 15, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up actionable console warnings surfaced by the test suite. All 39 packages continue to pass.
Changes
packages/table — React key prop spreading (4 files)
React 19 requires
keyto be passed directly to JSX, not via object spread. The react-table v7 helper methods (getHeaderGroupProps,getHeaderProps,getRowProps,getCellProps) return an object that includeskey, which was being spread onto the element.Fixed by destructuring
keyout of the returned props object and passing it explicitly:TableHeaderRow.tsxTableHeaderCell.tsxTableRow.tsxTableCell.tsxpackages/table —
displayTextfunction rendered as React childBulkRecordAction.displayTextaccepts a function signature(records, rows) => ReactNode, but the render code was doing{action.displayText}which passes the function itself as a child.Fixed by checking
typeof action.displayText === 'function'and calling it with the current selection when true. Snapshot updated accordingly.packages/date, packages/phone — Missing
act()wraps in testsSeveral tests triggered async Formik and react-dates state updates outside of
act(), causing noise in the test output.Fixed by wrapping the triggering
fireEventcalls inawait act(async () => {}):packages/date/tests/DateField.test.jsx— 3fireEvent.click(submit)callspackages/date/tests/DateRangeField.test.jsx— 3fireEvent.click(submit)callspackages/date/tests/DateRange.test.jsx— 3.focus()callspackages/phone/tests/Phone.test.jsx—fireEvent.change/fireEvent.blurpairsWhat's not fixed
Remaining warnings are all from third-party dependencies (reactstrap
defaultProps, availity-reactstrap-validation legacy context API, react-datescomponentWillMountlifecycle) and require upstream upgrades to resolve.