Repository navigation
List FEP-fe34 as partially supported in FEDERATION.md - #4071
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
The plugin already checks that an activity, its object and its key are on the same host as the actor (Announce, Delete, Accept, QuoteRequest, FeatureRequest, keys), and
Proxy::fetch_verified()only trusts a fetched object that is served under its ownid. That is the idea of FEP-fe34, with two differences: the plugin compares hosts, not scheme, host and port, and it does not treat other documents of the same origin as authoritative. I think the second one should stay that way, because on WordPress one origin is not always one owner (multisite in subdirectory mode, shared hosting with user folders).Context: swicg/activitypub-html-discovery#78
Other information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message