fix: support npm 12 installs#2955
Merged
Merged
Conversation
|
Contributor
Dependency Review SummaryThe full dependency review summary was too large to display here (1368KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
luismulinari
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the repository's Node.js dependency management to consistently use
package-lock.jsoninstead ofnpm-shrinkwrap.jsonacross all CI and workflow files. It also removes deprecated environment variables related to npm publishing and adds a configuration to.npmrc. Additionally, the migration documentation is updated to reflect these changes.CI and Workflow Updates:
ci.yml,devenv-e2e.yml,sea-build-sign.yml) to usepackage-lock.jsonfor caching dependencies instead ofnpm-shrinkwrap.json, ensuring consistency and compatibility with current npm versions. [1] [2] [3] [4] [5]NPM Publishing:
NPM_CONFIG_TAGenvironment variable and related comments fromnpm-publish.yml, asnpm-shrinkwrap.jsonis no longer used. [1] [2]Configuration:
allow-git=rootto.npmrc, possibly to support git-based dependencies at the root level.Documentation:
COMMANDER-MIGRATION.mdto reference the removal ofargsfrompackage-lock.jsoninstead ofnpm-shrinkwrap.json.Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom