Skip to content

Add devcontainer for faster GitHub Codespaces setup#4089

Merged
sejas merged 3 commits into
trunkfrom
add-devcontainer
Jul 6, 2026
Merged

Add devcontainer for faster GitHub Codespaces setup#4089
sejas merged 3 commits into
trunkfrom
add-devcontainer

Conversation

@sejas

@sejas sejas commented Jul 6, 2026

Copy link
Copy Markdown
Member

Related issues

How AI was used in this PR

  • AI helped to write the dev container definition

Proposed Changes

I suggest adding a GitHub dev container definition to launch GitHub Codespaces easily. It just installs the correct node version and project dependencies. We can consider installing more things like Claude CLI, or creating alias.
I find it especially useful for code reviews.

Testing Instructions

  • Create a codespace from this branch (Code → Codespaces → + Create a codespace on add-devcontainer)
  • Wait for postCreateCommand to finish
  • Run node apps/cli/dist/cli/main.mjs --help — should print CLI help without any manual setup
  • node --version should report v24.15.0
Screenshot 2026-07-06 at 15 32 55 Screenshot 2026-07-06 at 15 32 35

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Jul 6, 2026
@sejas sejas marked this pull request as ready for review July 6, 2026 14:34
@sejas sejas requested review from a team and wojtekn July 6, 2026 14:34

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this @sejas! This will help with reviews and quick testing. I have tested it, and it works as expected, I can see the CLI command output and the expected node version. LGTM!

CleanShot 2026-07-06 at 18 06 45@2x

Comment thread .devcontainer/devcontainer.json Outdated
"features": {
"ghcr.io/devcontainers/features/node:1": { "version": "24.15.0" }
},
"postCreateCommand": "npm ci && npm run cli:build && node apps/cli/dist/cli/main.mjs --help",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't see the output of node apps/cli/dist/cli/main.mjs --help so maybe that command can be avoided? I don't mind having that it there either

@wpmobilebot

wpmobilebot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing be5308c vs trunk

app-size

Metric trunk be5308c Diff Change
App Size (Mac) 1411.92 MB 1411.89 MB 0.03 MB ⚪ 0.0%

site-editor

Metric trunk be5308c Diff Change
load 1122 ms 743 ms 379 ms 🟢 -33.8%

site-startup

Metric trunk be5308c Diff Change
siteCreation 6515 ms 6502 ms 13 ms ⚪ 0.0%
siteStartup 2383 ms 2398 ms +15 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sejas sejas merged commit 1f7243a into trunk Jul 6, 2026
8 of 11 checks passed
@sejas sejas deleted the add-devcontainer branch July 6, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants