Wire up Add Site and Settings menu actions in agentic UI#4085
Open
wojtekn wants to merge 2 commits into
Open
Conversation
The application menu sends `add-site` and `user-settings` IPC events, but the agentic UI never subscribed to them, so the menu items and their ⌘N / ⌘, shortcuts did nothing. Subscribe to both events and navigate to the onboarding and settings routes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 63a3684 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used Claude Code to trace the menu → IPC → renderer flow, identify the missing subscriptions in the agentic UI connector, and implement the fix mirroring the existing
toggle-sidebar/toggle-site-previewhandlers. All changes were reviewed manually; typecheck, lint, and the related unit tests were run locally.Proposed Changes
With the agentic UI beta enabled, the "Add Site…" (⌘N) and "Settings…" (⌘,) application-menu items and their keyboard shortcuts did nothing. The Electron menu emits
add-siteanduser-settingsIPC events for both UIs, but the agentic UI only listened for the sidebar/preview toggles — so these two actions were silently dropped.The agentic UI now responds to both: "Add Site…" opens the new-site onboarding flow and "Settings…" opens the settings screen, from any route. This restores parity with the legacy UI and makes the advertised menu items and shortcuts actually work.
Testing Instructions
npm start).Pre-merge Checklist