Skip to content

fix(box-tree): correct paint, clipping, ID and viewport classification - #6223

Merged
chubes4 merged 1 commit into
trunkfrom
fix/issue-6220-blocks-engine
Nov 16, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
fix/issue-6220-blocks-engine

Conversation

@chubes4

@chubes4 chubes4 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the box-tree classifier false positives found on the first real capture (#6220). Schema v1 uses background/mask longhands; overflow is load-bearing only when a descendant exceeds the box; identity transforms do not paint; only referenced ids are semantic; sidecars record the viewports at which their document is served.

What changed

  • Replaced background and mask shorthands with longhands in the schema, contract, and fixtures, with no alias.
  • Made overflow clipping geometry-dependent, treated identity transforms as non-painting, and counted only referenced ids as semantic.
  • Accepted per-document viewport sets, and estimated the projection from block-producing boxes.

Verification

  • cd php-transformer && composer install -q && composer test: passed on de53175. Base trunk@bbfe1bc advanced to f0c403e. 120061 ms; retained gate metadata; output evidence link unavailable.
  • repro: none (no repro gate was declared, so these gates do not prove the issue).
  • CI: pending

Cook run
  • Gate 1: tree 986ca91b19c8b75ccb74f6ed3ce413bd40484954

Evidence

  • Publication identity: ambient_gh
  • Real Wix capture with longhand sidecars: neutral boxes About 52/358, Privacy 30/252, Home 117/622 (was 0 on every route); all source hashes valid; composer test green in the Cook gate.
  • Review form provenance: supplied by franklin using pi (claude-opus) rather than a recorded provider outcome.

AI disclosure

Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol.

Franklin wrote this review form after validating the candidate on a real capture, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.

Closes #6220

@chubes4
chubes4 merged commit a60f4f5 into trunk Nov 16, 2026
14 checks passed
@chubes4
chubes4 deleted the fix/issue-6220-blocks-engine branch November 16, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box-tree classifier: shorthand paint false positives, unreferenced ids, unconditional overflow; per-document viewports (ADR 0005)

1 participant