Skip to content

fix: preserve form and icon semantics during core button lowering - #6207

Open
chubes4 wants to merge 3 commits into
trunkfrom
fix/issue-5081-blocks-engine-2
Open

chubes4 wants to merge 3 commits into
trunkfrom
fix/issue-5081-blocks-engine-2

Conversation

@chubes4

@chubes4 chubes4 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixed control ownership regressions and editor parity. Local whole-site acceptance passed: 17→0 occurrences, no added blockers or visual regressions.

What changed

  • Preserved existing bound-control and provider-form conversion paths.
  • Used core/button labels while retaining native published button geometry.
  • Enabled control rendering runtime when needed.
  • Added a public-interface regression verified to fail before the fix and pass afterward.

Verification

  • acceptance=$(mktemp); bash "$IMPORT_LOOP_GATE" >"$acceptance" 2>&1 & gate=$!; (w: passed on 65e4b4b. Base trunk@2ad28f1 advanced to a60f4f5. 687666 ms; retained gate metadata; output evidence link unavailable.
  • repro: none (no repro gate was declared, so these gates do not prove the issue).
  • CI: pending

Cook run
  • Gate 1: tree d38e0ae3cb95a1145426ddc9e5af0f7de822345a

Evidence

  • All 17 previously failing PHP tests and the form geometry parity test pass.
  • Publication identity: ambient_gh
  • Whole-site diagnostic acceptance: pass=true, own=17→0, blockers_added=[], visual_regressions=[].

AI disclosure

Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol.

Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.

Closes #5081

@chubes4

chubes4 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Target occurrences fall from 17 to 0, but whole-site acceptance still fails on homepage typography.

  • Continued native-control lowering from the prior candidate.
  • Preserved button display restoration across shared route support sheets.
  • Verified the focused regression fails before the display fix and passes afterward; nearby tests pass.

Incomplete candidate; deterministic verification failed.

Task: #6207

incomplete_reason: Acceptance reports a new typography blocker for “Find parts” at 390px, 768px, and 1440px, with homepage visual regressions.

Candidate from attempt 3 (wf-import-findings-loop-07162be4f868-cook-i2-n3-a1-attempt-3-25ac9984).

Relates to #6207

Out-of-scope changes

  • php-transformer/src/HtmlToBlocks/Style/EngineSupportCss.php
  • php-transformer/tests/unit/button-shared-display.php
  • php-transformer/tests/unit/native-form-action-core.php

Gate: gate-1 — Failed

Gate output: gate-1

import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate phase=bare_wp seconds=1
Document body context: 29 assertions passed
Document body context browser: 126 checks across 21 route/viewport cells passed
import-loop-gate phase=contracts seconds=0
import-loop-gate phase=merge_onto_base seconds=0
import-loop-gate phase=reimport seconds=26
{"pass":false,"own":{"before":17,"after":0},"blockers_added":["4b422a4cc889:3"],"blockers_removed":["e99c506d8a3e:17->0"],"visual_regressions":["/@390","/@768","/@1440"],"visual_unmeasured":0}
import-loop-gate phase=accept seconds=327
import-loop-gate phase=bare_wp seconds=1
import-loop-gate phase=contracts seconds=0
import-loop-gate phase=merge_onto_base seconds=0
import-loop-gate phase=reimport seconds=26
import-loop-gate phase=accept seconds=327
import-loop-gate acceptance_exit=1 repository=skipped until acceptance passes

@chubes4
chubes4 marked this pull request as ready for review November 16, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non core block: authored-button

1 participant