Skip to content

fix: preserve captured choices as editable core groups - #6195

Merged
chubes4 merged 1 commit into
trunkfrom
fix/issue-6167-blocks-engine
Nov 16, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
fix/issue-6167-blocks-engine

Conversation

@chubes4

@chubes4 chubes4 commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Validated the inherited root-cause fix across the whole captured site and strengthened regression coverage.

  • Captured choices use core Groups with shared selection behavior.
  • Added public-interface assertions for accessible labels and shared runtime installation.

Incomplete candidate; deterministic verification failed.

Task: #6167

incomplete_reason: completion not assessed

Candidate from attempt 3 (wf-import-findings-loop-55d84b437573-cook-i1-n1-a1-attempt-3-c7edf148).

Closes #6167

Out-of-scope changes

  • php-transformer/src/HtmlToBlocks/Generators/AuthoredControlState.php
  • php-transformer/src/HtmlToBlocks/Generators/CapturedChoiceGroupBlockGenerator.php
  • php-transformer/src/WordPress/AuthoredControlStateScript.php
  • php-transformer/src/WordPress/CapturedChoiceGroupScript.php

Gate: gate-1 — Failed

Gate output: gate-1

import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate acceptance running
import-loop-gate phase=bare_wp seconds=0
Document body context: 29 assertions passed
Document body context browser: 126 checks across 21 route/viewport cells passed
import-loop-gate phase=contracts seconds=1
import-loop-gate phase=merge_onto_base seconds=0
import-loop-gate phase=reimport seconds=31
{"pass":false,"own":{"before":16,"after":0},"blockers_added":["ba5a797c79bc:1"],"blockers_removed":["643d082974b1:16->0"],"visual_regressions":[],"visual_unmeasured":0}
import-loop-gate phase=accept seconds=548
import-loop-gate phase=bare_wp seconds=0
import-loop-gate phase=contracts seconds=1
import-loop-gate phase=merge_onto_base seconds=0
import-loop-gate phase=reimport seconds=31
import-loop-gate phase=accept seconds=548
import-loop-gate acceptance_exit=1 repository=skipped until acceptance passes

@chubes4
chubes4 marked this pull request as ready for review November 16, 2026 06:49
@chubes4
chubes4 merged commit 37f5c72 into trunk Nov 16, 2026
28 checks passed
@chubes4
chubes4 deleted the fix/issue-6167-blocks-engine branch November 16, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non core block: captured-choice-group

1 participant