Skip to content

PSF interpolation order#950

Draft
oczoske wants to merge 3 commits into
mainfrom
oc/lms_cubic_interpolation
Draft

PSF interpolation order#950
oczoske wants to merge 3 commits into
mainfrom
oc/lms_cubic_interpolation

Conversation

@oczoske

@oczoske oczoske commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

This PR reverts the interpolation method used for the PSF back from RegularGridInterpolator to RectBivariateSpline. The appeal of RegularGridInterpolator was the availability of the pchip method, which however turns out to be not usable for 2D interpolation (excessive memory requirement). RectBivariateSpline is faster.

From a user perspective, the PSF interpolation methods opens up the interpolation order as a user-settable parameter, !SIM.psf.interp_order. For consistency, we also define !SIM.psf.interp_psf (formerly !OBS.interp_psf) to control whether the PSF is scaled to each wavelength slice of a spectral cube or just once to the central wavelength.

@oczoske oczoske self-assigned this Jul 5, 2026
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) API How users interact with the software effects Related to a ScopeSim effect performance Execution speed or memory consumtion labels Jul 5, 2026
@oczoske oczoske moved this to 🏗 In progress in ScopeSim-development Jul 5, 2026
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.17%. Comparing base (ac9c592) to head (4e5b2f2).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/effects/psfs/discrete.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   75.18%   75.17%   -0.01%     
==========================================
  Files          70       70              
  Lines        9025     9027       +2     
==========================================
+ Hits         6785     6786       +1     
- Misses       2240     2241       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API How users interact with the software effects Related to a ScopeSim effect enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) performance Execution speed or memory consumtion

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

1 participant