Skip to content

Add min_solar_elevation parameter to plot_shading_heatmap #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamRJensen merged 3 commits into from
Sep 23, 2026
Merged

Add min_solar_elevation parameter to plot_shading_heatmap #146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7ebda1
Add min_solar_elevation parameter to plot_shading_heatmap
AdamRJensen Sep 21, 2026
315e142
Update default limit to 0.5
AdamRJensen Sep 21, 2026
0d293db
Merge branch 'main' into AdamRJensen-patch-3
AdamRJensen Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/solarpy/plotting/shading_heatmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def plot_shading_heatmap(
value: Any,
solar_azimuth: Any,
solar_elevation: Any,
min_solar_elevation: float = 0.5,
azimuth_bin_size: float = 1.0,
elevation_bin_size: float = 1.0,
encoding: Callable[[np.ndarray], float] | str = "max",
Expand Down Expand Up @@ -47,6 +48,9 @@ def plot_shading_heatmap(
solar_elevation : array-like of float
Solar elevation angle in degrees (0–90 above the horizon). Must
be the same length as *value*.
min_solar_elevation : array-like of float
Minimum solar elevation angle in degrees for which to use data
for. Default is ``0.5``.
azimuth_bin_size : float, optional
Width of each azimuth bin in degrees. Default is ``1.0``.
elevation_bin_size : float, optional
Expand Down Expand Up @@ -127,7 +131,7 @@ def plot_shading_heatmap(
solar_elevation = np.asarray(solar_elevation, dtype=float)

# Discard sub-horizon data and non-finite values (nan and inf)
above_and_finite = (solar_elevation >= 0) & np.isfinite(value)
above_and_finite = (solar_elevation >= min_solar_elevation) & np.isfinite(value)
value = value[above_and_finite]
solar_azimuth = solar_azimuth[above_and_finite]
solar_elevation = solar_elevation[above_and_finite]
Expand Down
Loading