Header footer nav update#3500
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the site’s global header/footer integration in the Arm Design System Hugo theme, primarily by expanding arm-top-navigation / arm-footer-navigation configuration and adjusting styling/behavior for the updated navigation components.
Changes:
- Updated masthead markup to pass additional attributes to
<arm-top-navigation>(breakpoint, theme, routing, hostname, language, animation flag). - Switched the Arm global web components bundle URL and made the script deferred.
- Adjusted navigation placeholder/fixer CSS (height + backgrounds) and tweaked the sign-in redirect button label.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| themes/arm-design-system-hugo-theme/static/js/authentication.js | Updates sign-in button redirect messaging during login redirect. |
| themes/arm-design-system-hugo-theme/layouts/partials/header/nav-masthead.html | Adds configuration attributes to <arm-top-navigation> for consistent dark-themed global navigation behavior. |
| themes/arm-design-system-hugo-theme/layouts/partials/head/head.html | Changes which Arm global web components bundle is loaded (and defers it). |
| themes/arm-design-system-hugo-theme/layouts/partials/footer/footer.html | Configures <arm-footer-navigation> with explicit lang/theme attributes. |
| assets/css/cross-page.css | Updates reserved nav height and background styles for the global nav container and hydration placeholder. |
| <!-- Arm Header & Footer loading. | ||
| TODO: Replace the test bundle with its production URL when Arm publishes it. --> | ||
| <script | ||
| type="text/javascript" | ||
| src="https://www.arm.com/arm-global-web-components/devhub/test.js" | ||
| defer> | ||
| </script> |
There was a problem hiding this comment.
This is intentionally using the test bundle while the refreshed DevHub header and footer are being validated. Before merging or promoting this change to production, we need the component owner to provide or confirm the stable production bundle URL. We will then update the production default to that URL. The internal environment may continue using test.js for validation, but learn.arm.com should not depend on the test artifact.
Before submitting a pull request for a new Learning Path, please review Create a Learning Path
Please do not include any confidential information in your contribution. This includes confidential microarchitecture details and unannounced product information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the Creative Commons Attribution 4.0 International License.