Adsv5 feedback notes#3499
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Arm Learning Paths Hugo theme to align with ADS v5 “color refresh” styling, including refreshed dark-theme surfaces, updated topic icons, and adjusted masthead/search presentation.
Changes:
- Refreshes dark-theme colors across list pages, content containers, the homepage, and masthead/breadcrumb surfaces.
- Adds a dismissible, site-wide “color refresh” alert (excluded from the homepage) persisted via
localStorage. - Updates homepage main-topic icon handling and adds new SVG icons for select topics.
Reviewed changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| themes/arm-design-system-hugo-theme/static/img/main-topic-icons/Premium Phone.svg | Adds new “Premium Phone” topic icon asset (note: filename contains a space). |
| themes/arm-design-system-hugo-theme/static/img/main-topic-icons/Microcontroller.svg | Adds new microcontroller topic icon asset. |
| themes/arm-design-system-hugo-theme/static/img/main-topic-icons/Cloud.svg | Adds new cloud topic icon asset. |
| themes/arm-design-system-hugo-theme/static/img/main-topic-icons/AI_2.svg | Adds new AI topic icon asset. |
| themes/arm-design-system-hugo-theme/layouts/partials/header/nav-masthead.html | Applies new masthead background utility class and updates masthead heading markup. |
| themes/arm-design-system-hugo-theme/layouts/partials/header/masthead.html | Applies new masthead background utility class and updates masthead heading markup. |
| themes/arm-design-system-hugo-theme/layouts/partials/header/color-refresh-alert.html | Introduces a dismissible “color refresh” alert with localStorage persistence. |
| themes/arm-design-system-hugo-theme/layouts/partials/filter-search-sort/open-expansion.html | Updates filter search component styling/props for dark theme. |
| themes/arm-design-system-hugo-theme/layouts/partials/filter-search-sort/mobile-search-and-filter.html | Updates mobile search placeholder and applies dark theme styling. |
| themes/arm-design-system-hugo-theme/layouts/partials/filter-search-sort/csp-term-page.html | Updates term-page search placeholder and applies dark theme styling. |
| themes/arm-design-system-hugo-theme/layouts/install-guides/list.html | Updates install-guide search, card wrapper class, and hover behavior. |
| themes/arm-design-system-hugo-theme/layouts/index.html | Updates CTA styling, homepage search styling, and main-topic icon filename logic and assets. |
| themes/arm-design-system-hugo-theme/layouts/_default/baseof.html | Injects the site-wide alert partial on non-home pages. |
| assets/css/stats.css | Adjusts hover styling for stats cards in refreshed palette. |
| assets/css/list-pages.css | Updates dark-theme ADS component tokens and list/card styling to new surfaces/borders. |
| assets/css/home.css | Updates homepage card surfaces, icon treatment, and title colors for dark theme. |
| assets/css/cross-page.css | Updates search button color, masthead/breadcrumb backgrounds, and removes legacy gradient/background image styling. |
| assets/css/content.css | Updates dark-theme main/content container surfaces. |
| assets/css/content-pages.css | Removes prior masthead title clamping styles and updates dark-theme card surfaces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request for a new Learning Path, please review Create a Learning Path
Please do not include any confidential information in your contribution. This includes confidential microarchitecture details and unannounced product information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the Creative Commons Attribution 4.0 International License.