Open PR for Vulkan update#3492
Conversation
|
This is for review from AI-ML-SDK team |
…mple/images/VL availble .png
…mple/images/VL Config.png
…mple/images/c ext.png
…mple/images/cmake ext.png
annietllnd
left a comment
annietllnd
left a comment
There was a problem hiding this comment.
Thank you for the update! A few comments from me as a first pass :)
| Next, enable the emulation layers using the Vulkan Configurator to simulate the `VK_ARM_data_graph` and `VK_ARM_tensors` extensions. Open **Vulkan Configurator**. | ||
|
|
||
| Under the **Vulkan Layers Location** tab, add the path to your `MLEmulationLayerForVulkan` folder. | ||
| Under the **Vulkan Layers Available** tab, add the path to your `Emulation layer` folder that can be found in the site packages of your venv folder select the bin folder. |
There was a problem hiding this comment.
What folder exactly? Be as specific as you can
|  | ||
|
|
||
|
|
||
| Create a Venv in Python (3.13 was used in the creation of this Guide) and run the following commands |
There was a problem hiding this comment.
Instead of writing the instruction out, I would simply insert the command
python3.13 -m venv .venv
|
|
||
|
|
||
| Switch back to the **Vulkan Loader Management** tab. In the **Apply a Vulkan Loader Configuration** list, right-click and choose **Create a new Configuration**. You can give the new configuration any name, for example `tensor_and_data_graph`. | ||
|  |
There was a problem hiding this comment.
I'd blackout the rest of the path up until 'venv', so that the path on your local machine isn't exposed. You can keep the description of the image ("Screenshot of the Vulkan...")
|  | ||
|
|
||
|  | ||
| Under the **Vulkan layers Configuration** tabgo through each setting in the top rigt except disable all Vulkan Layers and enable the Graph and Tensor Emulation |
There was a problem hiding this comment.
Make an agent pass of this update to catch little spelling mistakes like this one
| Ensure that the **Graph** layer is listed above the **Tensor** layer. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Is there an option here to leave out the other layers? Try clicking the dropdown "Show all available layers". This'll make it easier for the reader to spot what they are looking for in their own setup
There was a problem hiding this comment.
I haven't found that option myself in the configurator. Will have another pass
|
|
||
| ## Setting up Visual studio build tools | ||
|
|
||
| o build the Vulkan Samples on Windows using the Visual Studio generator, you still need the Microsoft C++ compiler and build tools. |
There was a problem hiding this comment.
The "Desktop development with C++" is listed as a prerequisite to the Learning Path itself, is this the same thing you're describing here?
There was a problem hiding this comment.
Alright, in that case this part can be omitted :)
nlithammer
left a comment
nlithammer
left a comment
There was a problem hiding this comment.
NGP is an internal name. Please avoid it in PR name.
|
Ammended PR title |
3 participants
Before submitting a pull request for a new Learning Path, please review Create a Learning Path
Please do not include any confidential information in your contribution. This includes confidential microarchitecture details and unannounced product information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the Creative Commons Attribution 4.0 International License.