fix(engine): enrich only newly created opportunity sessions - #5
Merged
Merged
Conversation
HandlePulseEvent returns (nil, nil) for a duplicate pulse EventID, but the aggregator treated nil error as 'enrich again', spawning a second watch goroutine on the same session. Enrich only when a session was actually created; regression test counts enrichment spawns for a duplicated event.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Duplicate pulse events (
EventIDrepeats) no longer spawn a second async enrichment goroutine on the same OpportunitySession.HandlePulseEventreturns(nil, nil)when the session already exists, but the aggregator treated a nil error as "enrich again". Now enrichment only starts when a session was actually created:Why
Two watch goroutines on one session means double OHLCV fetching, duplicate cycle work, and two writers racing to attach tickets to the same session. Non-blocker caught in PR #4 review; this is the cleanup PR.
Verification
TestEventAggregator_DuplicatePulseEnrichesOnce: feeds the samemarket_impulseEventID twice, asserts exactly one enrichment spawn (fails with 2 spawns on the old code — confirmed)make checkgreen (build / vet / fmt / mod / lint / test -race)Closes the follow-up from #4 review.