Repository navigation
Declare effects and guard uncertain writes in agent plans - #61
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner could execute porcelain commands such as
session-end --commit-message … --pushpast an uncertain write, then report a partially completed porcelain step as having no commit. Classification also depended on whether the plan contained ausestep.One executing registry now owns the classification. Every operation declares
read,derived-write,canonical-write, or defaults tounknown; only explicit reads avoid the write barrier. This includes file output behind query/tool kinds, such as validation reports, analysis staging, backup export/verification, search indexing, and dossier caching. Bothargvanduserequire a stable session for effectful steps; descriptions remain reads.All dispatched writers begin uncertain. Receipt evidence establishes commitment and cannot be erased by a contradictory refusal field. Only a genuine gateway refusal can establish no commit; generic porcelain failures cannot prove that no files or Git state changed. Later writes are skipped under continue policy, while independent reads remain available.
Receipt verification now rejects paths outside
operations/transactions/before opening them, including escapes and symlinks.Validation: 32 added regression cases, including a real fixture Git commit followed by push failure with no remote configured. A total of 491 focused/architecture/efficiency/catalogue/document-command tests pass, along with ruff, mypy, import boundaries, reachability, system-map checks, zero validation errors, and the unchanged warning baseline. The fixtures do not touch the live checkout or push to any remote.
Exact hosted Core/UI gate succeeded for Core
17ce3dba1fd05607e3c68634a20acc079124ecf4and UI5a6bbeebc0b8a4dbfa1977bb8d4c223541023348. Local checks are not a full acceptance claim. The unrelated scheduled URL audit failure was investigated and recorded in #62 without changing source identities or suppressing its checks.Fixes #60. Fixes #63.