Skip to content

fix(gui): show wheel controls without adjustable dpi - #1369

Open
minatoaquaMK2 wants to merge 1 commit into
AprilNEA:masterfrom
minatoaquaMK2:fix/show-wheel-controls-without-dpi
Open

minatoaquaMK2 wants to merge 1 commit into
AprilNEA:masterfrom
minatoaquaMK2:fix/show-wheel-controls-without-dpi

Conversation

@minatoaquaMK2

Copy link
Copy Markdown

Summary

M720 exposes wheel inversion and HiRes Wheel support without adjustable DPI, so the desktop app hid the Pointer tab even though its wheel controls were usable. Show the Pointer tab whenever any pointer or wheel control is available.

Changes

  • openlogi-desktop: gate the Pointer tab on adjustable DPI, wheel inversion, or HiRes Wheel capability.
  • openlogi-desktop: add regression coverage for wheel-capable mice that do not expose adjustable DPI.

Testing

  • cargo +1.98.0 fmt --all -- --check
  • cargo +1.98.0 test -p openlogi-desktop --features gpui_platform/runtime_shaders (214 passed)
  • RUSTFLAGS="-D warnings" cargo +1.98.0 clippy -p openlogi-desktop --all-targets --features gpui_platform/runtime_shaders -- -D warnings
  • RUSTFLAGS="-D warnings" cargo +1.98.0 clippy --workspace --all-targets -- -D warnings (GPUI runtime shaders enabled locally because this host has Command Line Tools without the Metal compiler)
  • RUSTDOCFLAGS="-D warnings" cargo +1.98.0 doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agent
  • Hardware verified with a Bluetooth-direct M720 TRIATHLON: the Pointer tab is visible and the wheel inversion control loads with the current inverted state.
  • The default build-time Metal shader path was not run because full Xcode is unavailable on this host.

Hardware verification

M720 Pointer tab with wheel inversion enabled

Fixes #1096

@greptile-apps

greptile-apps Bot commented Sep 12, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the broadened gate exposes existing capability-aware controls without introducing an established failure.

Summary

  • Updates the capability gate to recognize either wheel capability.
  • Adds regression coverage for wheel-capable devices without adjustable DPI.

Reviews (1) · Last reviewed commit: "fix(gui): show wheel controls without ad..."

@davidbudnick davidbudnick added type: bug Something is broken or behaves incorrectly area: gui Graphical user interface platform: all Cross-platform issue labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: gui Graphical user interface platform: all Cross-platform issue type: bug Something is broken or behaves incorrectly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:M720 Triathlon 鼠标滚轮方向修改不了

2 participants