fix(gui): show wheel controls without adjustable dpi - #1369
Open
minatoaquaMK2 wants to merge 1 commit into
Open
minatoaquaMK2 wants to merge 1 commit into
minatoaquaMK2 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M720 exposes wheel inversion and HiRes Wheel support without adjustable DPI, so the desktop app hid the Pointer tab even though its wheel controls were usable. Show the Pointer tab whenever any pointer or wheel control is available.
Changes
openlogi-desktop: gate the Pointer tab on adjustable DPI, wheel inversion, or HiRes Wheel capability.openlogi-desktop: add regression coverage for wheel-capable mice that do not expose adjustable DPI.Testing
cargo +1.98.0 fmt --all -- --checkcargo +1.98.0 test -p openlogi-desktop --features gpui_platform/runtime_shaders(214 passed)RUSTFLAGS="-D warnings" cargo +1.98.0 clippy -p openlogi-desktop --all-targets --features gpui_platform/runtime_shaders -- -D warningsRUSTFLAGS="-D warnings" cargo +1.98.0 clippy --workspace --all-targets -- -D warnings(GPUI runtime shaders enabled locally because this host has Command Line Tools without the Metal compiler)RUSTDOCFLAGS="-D warnings" cargo +1.98.0 doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agentHardware verification
Fixes #1096