fix(i18n): name the real update host instead of GitHub in consent text - #1365
Open
4ni1ak wants to merge 1 commit into
Open
fix(i18n): name the real update host instead of GitHub in consent text#13654ni1ak wants to merge 1 commit into
4ni1ak wants to merge 1 commit into
Conversation
update_consent_description said OpenLogi checks GitHub for a new version, but the actual manifest request goes to updates.openlogi.org (see UpdaterConfig::default in crates/openlogi-desktop/src/platform/updater.rs). A user auditing outgoing connections would see traffic to a host the copy never mentions. Update the string in every locale catalog to name updates.openlogi.org instead.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| check_for_updates_consent_title = "Check for updates?" | ||
| update_consent_description = "OpenLogi can check GitHub for a new version once per launch. It does not download updates automatically or send telemetry. You can change this in Settings." | ||
| update_consent_description = "OpenLogi can check updates.openlogi.org for a new version once per launch. It does not download updates automatically or send telemetry. You can change this in Settings." | ||
|
|
There was a problem hiding this comment.
If a custom or self-hosted build overrides OPENLOGI_UPDATE_MANIFEST_URL, this text still says the request goes to updates.openlogi.org. Accepting the consent immediately runs the updater against the configured endpoint, so users can be told one host while the application contacts another. The same hard-coded host appears in the other 22 changed locale catalogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
crates/openlogi-desktop/src/platform/updater.rsbuilds the manifest URL fromUpdaterConfig::default, which points athttps://updates.openlogi.org/channels/stable/latest.json. Theupdate_consent_descriptionstring in every locale catalog named GitHub instead, which is misleading for a user auditing outgoing connections — the traffic never reaches github.com.Changes
crates/openlogi-ui/locales/*.toml(all 23 catalogs): rewordedupdate_consent_descriptionto nameupdates.openlogi.orginstead of GitHub, translated literally per locale. No keys added or removed.Testing
cargo fmt --all -- --checkcargo clippy -p openlogi-ui -p openlogi-desktop --all-targets -- -D warningscargo test -p openlogi-ui locale(catalog key-parity across all locale files)cargo test -p openlogi-desktop i18n(catalog wiring)Fixes #1342