fix(i18n): name the real update host in the consent string - #1344
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
The update consent copy told users OpenLogi checks GitHub for a new version, but the updater reads its manifest from https://updates.openlogi.org/channels/stable/latest.json. `release.yml` generates that manifest with xtask and uploads it to R2 instead of attaching `latest.json` to the GitHub release, and the only GitHub URL left in the asset/update path is the User-Agent. The copy is a stale remnant of the updater's move to the static manifest. Update `update_consent_description` in all 23 catalogs in one change so the key set, key order, and placeholders stay aligned across locales. Refs AprilNEA#1342
|
Author
|
The configured-host caveat is valid for builds that set |
dajiaohuang
force-pushed
the
fix/update-consent-real-host
branch
from
September 11, 2026 10:51
82fac61 to
f26a4e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The update-consent string told users OpenLogi checks GitHub for a new version, but the client fetches its manifest from
https://updates.openlogi.org/channels/stable/latest.json, so the copy named a host the check never contacts.The string is a leftover from before the updater moved to the static manifest:
release.ymlgenerateslatest.jsonwith xtask and uploads it to R2 rather than attaching it to the GitHub release, and the only GitHub URL left in the asset/update path is theUser-Agent.Changes
openlogi-ui:update_consent_descriptionnow namesupdates.openlogi.orgin all 23 catalogs, so the key set, key order, and%{}placeholders stay aligned. Two locales needed the sentence restructured around the new token rather than a straight swap (fi,pl).Testing
cargo test -p openlogi-ui locale— catalog parity passes (locale_files_have_the_same_keys).cargo fmt --all -- --check— clean.RUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets -- -D warnings— clean.cargo test --workspace— one failure,xtaskci_yml_runs_what_this_runner_runs. It is pre-existing and unrelated: it reproduces on a pristinegit worktreeat the base commit with none of these changes applied, and it asserts on.github/workflows/ci.ymlversus the xtask job plan, neither of which this change touches.updates.openlogi.orgrather thanGitHub.Overlap
Open PR #1326 rewrites this same
es.tomlline while keeping theGitHubwording, so whichever of the two lands second needs a trivial rebase on that one line. I did not fold this into #1326 because it is another contributor's branch and its scope is theescatalog only, whereas all 23 catalogs carry the same wrong host.Fixes #1342
🤖 Generated with Claude Code