Skip to content

fix(i18n): name the real update host in the consent string - #1344

Open
dajiaohuang wants to merge 1 commit into
AprilNEA:masterfrom
dajiaohuang:fix/update-consent-real-host
Open

dajiaohuang wants to merge 1 commit into
AprilNEA:masterfrom
dajiaohuang:fix/update-consent-real-host

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

The update-consent string told users OpenLogi checks GitHub for a new version, but the client fetches its manifest from https://updates.openlogi.org/channels/stable/latest.json, so the copy named a host the check never contacts.

The string is a leftover from before the updater moved to the static manifest: release.yml generates latest.json with xtask and uploads it to R2 rather than attaching it to the GitHub release, and the only GitHub URL left in the asset/update path is the User-Agent.

Changes

  • openlogi-ui: update_consent_description now names updates.openlogi.org in all 23 catalogs, so the key set, key order, and %{} placeholders stay aligned. Two locales needed the sentence restructured around the new token rather than a straight swap (fi, pl).

Testing

  • cargo test -p openlogi-ui locale — catalog parity passes (locale_files_have_the_same_keys).
  • cargo fmt --all -- --check — clean.
  • RUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets -- -D warnings — clean.
  • cargo test --workspace — one failure, xtask ci_yml_runs_what_this_runner_runs. It is pre-existing and unrelated: it reproduces on a pristine git worktree at the base commit with none of these changes applied, and it asserts on .github/workflows/ci.yml versus the xtask job plan, neither of which this change touches.
  • Not runtime-tested on hardware. To verify: open Settings → Updates and confirm the consent text under the update-checking toggle reads updates.openlogi.org rather than GitHub.

Overlap

Open PR #1326 rewrites this same es.toml line while keeping the GitHub wording, so whichever of the two lands second needs a trivial rebase on that one line. I did not fold this into #1326 because it is another contributor's branch and its scope is the es catalog only, whereas all 23 catalogs carry the same wrong host.

Fixes #1342

🤖 Generated with Claude Code

The update consent copy told users OpenLogi checks GitHub for a new
version, but the updater reads its manifest from
https://updates.openlogi.org/channels/stable/latest.json.

`release.yml` generates that manifest with xtask and uploads it to R2
instead of attaching `latest.json` to the GitHub release, and the only
GitHub URL left in the asset/update path is the User-Agent. The copy is
a stale remnant of the updater's move to the static manifest.

Update `update_consent_description` in all 23 catalogs in one change so
the key set, key order, and placeholders stay aligned across locales.

Refs AprilNEA#1342
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or newly introduced issues.

Summary

  • Keeps the localized catalog keys and placeholders aligned.
  • Restructures the Finnish and Polish wording around the replacement hostname.
  • No changes were made after the previous review.

Reviews (2) · Last reviewed commit: "fix(i18n): name the real update host in ..."

Comment thread crates/openlogi-ui/locales/en.toml
@dajiaohuang

Copy link
Copy Markdown
Author

The configured-host caveat is valid for builds that set OPENLOGI_UPDATE_MANIFEST_URL; this PR keeps the consent copy aligned with the shipping default updates.openlogi.org across the official locale catalogs. Making the host dynamic in localized consent text would be a separate design change, so I am leaving this non-blocking finding unchanged.

@dajiaohuang
dajiaohuang force-pushed the fix/update-consent-real-host branch from 82fac61 to f26a4e7 Compare September 11, 2026 10:51
@davidbudnick davidbudnick added type: bug Something is broken or behaves incorrectly platform: all Cross-platform issue labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: all Cross-platform issue type: bug Something is broken or behaves incorrectly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Update consent dialog says "check GitHub" but the check goes to updates.openlogi.org

2 participants