Skip to content

use proper ipv4 binding #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noboruma wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use proper ipv4 binding #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions socks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def bind(self, *pos, **kw):
# some relays drop packets if a port of zero is specified.
# Avoid specifying host address in case of NAT though.
_, port = self.getsockname()
dst = ("0", port)
dst = ("0.0.0.0", port)

self._proxyconn = _orig_socket()
proxy = self._proxy_addr()
Expand Down Expand Up @@ -818,7 +818,7 @@ def connect(self, dest_pair, catch_errors=None):
# Protocol error while negotiating with proxy
self.close()
raise

@set_self_blocking
def connect_ex(self, dest_pair):
""" https://docs.python.org/3/library/socket.html#socket.socket.connect_ex
Expand All @@ -828,7 +828,7 @@ def connect_ex(self, dest_pair):
self.connect(dest_pair, catch_errors=True)
return 0
except OSError as e:
# If the error is numeric (socket errors are numeric), then return number as
# If the error is numeric (socket errors are numeric), then return number as
# connect_ex expects. Otherwise raise the error again (socket timeout for example)
if e.errno:
return e.errno
Expand Down