[Feature] Hovering over cooking recipe in cooking menu shows if player has not yet cooked recipe#225
[Feature] Hovering over cooking recipe in cooking menu shows if player has not yet cooked recipe#225DustinsCode wants to merge 4 commits intoAnnosz:masterfrom DustinsCode:master
Conversation
Started on feature to determine if craftable item is in collection. Currently prints to SMAPI if cookable recipe is in player's collection.
Queen of Sauce displays in texturebox when hovering over cookable recipe player has not cooked yet
|
@Annosz This has been done, any chance of getting it merged in? :) |
| public void Dispose() | ||
| { | ||
| throw new NotImplementedException(); | ||
| } |
There was a problem hiding this comment.
Is the exception thrown on purpose or can it be safely removed ?
|
Hi! Yes @tqdv, you can merge anything you find appropriate, I've seen a lot of high quality additions from you, so I trust your judgement :) Sorry for the constant delay @DustinsCode on reviewing PRs, I hope now that @tqdv also has the right to accept them, the update cycle can be shorter. I second the comment about 'showHoverCraftableInCollection' having a separate option in the config menu, it is a big enough feature. My only feedback is that would prefer consistency with existing functions, so if the icon had the same placing as the Full Shipment indicator, at the top left corner of the box: |
|
Hi, it's been a while since I've looked at this. Very busy with work and all. Last time I did look at this, I was trying to come up with a way to place the tool tip in the way mentioned above, but was struggling to get it placed in relation to the existing recipe tool tip, since that box's size can change depending on the content inside of it. I'll have another go at it maybe this week or next as well as address the other suggestions |
|
It would be great to be able to see if the player has already cooked that meal or not (for achievement purposes). |
@TaciteOFF Thanks for reminding me about this (and giving me some extra motivation to actually finish it)! I should have some time after work this week to pull this back up, get it updated, and hopefully get it in a ship-able state |
|
This PR is super outdated and it's looking to be a pain to update. I'm going to close this so I can get my fork properly updated and then re-do some of this. |
|
I opened a new PR for this feature with slightly expanded functionality for both cooking and crafting recipes! #528 |
5 participants
Related issue: #224
Problem
Currently, when trying to complete the Master Chef achievement, one must first check the collections menu in order to see if a recipe they have the ingredients for has already been cooked and added to the collection. Sometimes they can make a mistake and spend precious ingredients on a recipe they have already made! Frustrating.
Solution
I have added a
TextureBoxthat appears next to the cursor when hovering over a cooking recipe (only unlocked recipes, of course) that simply displays our beloved Queen of Sauce if the player has not yet cooked it. This takes out all of the back and forth checking between menus.PSA
This was my first time ever trying something in the SV modding world as well as in the C# world.
Please let me know if there are any revisions you would like me to make! 😄
Screenshots
(Please excuse my other active mods)
Player has not yet cooked the Pink Cake, so Queen of Sauce is displayed.
Player has cooked the Fried Calamari, so Queen of Sauce is not displayed.