fix(security): enable webSecurity to restore same-origin policy (CWE-1021)#244
Open
nobugpal wants to merge 1 commit into
Open
fix(security): enable webSecurity to restore same-origin policy (CWE-1021)#244nobugpal wants to merge 1 commit into
nobugpal wants to merge 1 commit into
Conversation
Set webSecurity: true to restore same-origin policy enforcement. Previously disabled (webSecurity: false) which allowed the renderer to make arbitrary cross-origin requests from file:// protocol. This is a defense-in-depth fix per Electron security best practices: https://www.electronjs.org/docs/latest/tutorial/security CWE: CWE-1021 - Improper Restriction of Rendered UI Layers or Frames Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Same-Origin Policy Completely Disabled — All Desktop Users Affected
CWE-1021 — Improper Restriction of Rendered UI Layers or Frames
electron/main.js:26configureswebSecurity: false, which disables the browser's most fundamental security boundary — the Same-Origin Policy (SOP).Attack Scenario
webSecurity: falsegrants unrestricted cross-origin accesslocalStorage.getItem('muapi_key')ordocument.cookiefetch()to attacker-controlled serverfile:///etc/passwdor local file reads via fetchRoot Cause
Why This Matters
webSecurity: falseis explicitly listed in Electron's security guide as a must-not-do security violation. WhilecontextIsolation: trueprevents direct Node.js access, disabling SOP amplifies any minor content injection (XSS, plugin, MCP, AI output) into a critical credential theft + data exfiltration + local file read chain.Every Electron security audit ranks this as a top-3 finding. See CVEs in similar apps: DeepChat (CVE-2025-67744, XSS-to-RCE via Electron misconfiguration), 5ire (CVE-2025-47777).
Fix Verification
false→trueapi.muapi.aiare unaffected by SOPReferences
Co-Authored-By: Claude noreply@anthropic.com