Repository navigation
Discriminant overlap in inference: distribute source, use comparability, optional fast path - #5
Merged
Andarist merged 2 commits intoOct 22, 2026
Conversation
Andarist
force-pushed
the
experiment/discriminant-overlap-rework
branch
from
October 22, 2026 07:22
f2f1fbe to
e045b7a
Compare
Andarist
merged commit Oct 22, 2026
e045b7a
into
fix-go/contextual-inference-discriminants
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
fix-go/contextual-inference-discriminants(microsoft#64695). Four commits, meant to be read in order:broadContext,partialTagContext,unionTagContext,indexedContext,eitherContext), andclassExtendedDiscriminatedUnionInference.tsported from During inference discriminate the target type before falling back to close-matching types microsoft/TypeScript#43853. Baselines reflect the PR as it stands, so the regressions againstmainare visible in this commit.tag?: "a",ok: true | undefined, index signatures) never matched. Swapping which side gets distributed fixes everything exceptbroadContext.broadContext(kind: stringcontextual constituent) is the case assignability cannot get right. Comparability is the complement relation; relation checking and contextual typing keep assignability since their direction is fixed.strictNullChecks, so skip the property type resolution and the comparisons. This commit moves no baselines.Full local compiler suite passes on the tip. Compare against the PR branch: fix-go/contextual-inference-discriminants...experiment/discriminant-overlap-rework