test: cover scan and classify instrument harness tools - #26
Merged
Merged
Conversation
scan_tool.py and classify_tool.py had no dedicated tests. Add 8 unit tests with the VISA scanner monkeypatched (no PyVISA or hardware needed): scan success/empty/error paths and schema, classify with provided data vs live-scan fallback, unknown measurement type, and invalid instrument data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护
改动：为此前无专属测试的
harness/tools/scan_tool.py与classify_tool.py新增tests/test_scan_classify_tools.py（8 个用例）：scan 成功 / 空结果 / 异常 / schema；classify 使用传入数据、回退实时扫描、未知测量类型、非法仪器数据。VISA 扫描器全部 monkeypatch，无需 PyVISA 或硬件；分类走真实内置查表。测试：通过（本地全量 399 passed / 1 skipped；ruff check + format 通过）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code