test: cover planning.safety_advisor prompt building and gating - #21
Merged
Merged
Conversation
safety_advisor.py had zero test coverage even though the boundary checker calls it whenever a plan triggers warnings. Add unit tests with a mocked LLM router for the no-credentials early return, base_url-only endpoints, reply whitespace stripping, and the exact prompt layout (with and without a sample description). Coverage 0% -> 100%; no source changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（测试覆盖）
改动：为此前零覆盖的
planning/safety_advisor.py（边界检查触发警告时调用的 LLM 安全建议）新增 5 个单元测试，mock LLM router：无凭据早退且不构建 router、仅 base_url 的本地端点、回复去空白、prompt 的完整格式（含/不含样品描述）。覆盖率 0% → 100%，未改任何源码。测试：通过（本地全量 296 passed / 1 skipped；ruff check + format 通过）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code