forked from conda-forge/python_abi-feedstock
-
Notifications
You must be signed in to change notification settings - Fork 0
python_abi build 5: add free-threading track_features on t variants #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
75dedfa
Add track_features on free-threaded python_abi
skupr-anaconda c14e3cf
Fix PBP zip_keys clash with aggregate python matrix
skupr-anaconda f4b8c2c
Match python track_features names per version on t abi
skupr-anaconda 5a61541
Use selectors
skupr-anaconda c6092ef
Remove jinja2 stuff
skupr-anaconda 029eee5
Revert python_minor
skupr-anaconda d43b494
Set build number to 5
skupr-anaconda f41e6fc
Fix t track_features selectors (and, not or)
skupr-anaconda a949ba7
Limit free-threading track_feature to 3.14t
skupr-anaconda 38b4432
Update recipe/meta.yaml
skupr-anaconda d954d6d
Update recipe/meta.yaml
skupr-anaconda a11180c
Apply suggestion from @cbouss
skupr-anaconda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| {% set build_num = 4 %} | ||
| {% set build_num = 5 %} | ||
| {% if python_impl_version is not defined %} | ||
| {% set python_impl_version = "3.8" %} | ||
| {% endif %} | ||
|
|
@@ -16,12 +16,17 @@ package: | |
| build: | ||
| number: {{ build_num }} | ||
| string: {{ build_num }}_{{ python_abi_tag }} | ||
| track_features: # [python_implementation != "cpython"] | ||
| track_features: | ||
| - pypy # [python_implementation == "pypy"] | ||
| - native_graalpy # [python_implementation == "graalpy"] | ||
| # Required for PBP. | ||
| - freethreading # [python_implementation == "cpython" and python_abi_tag.endswith("t")] | ||
| # force_ignore_keys required for PBP. Ignore aggregate python zip_keys (numpy / | ||
| # is_freethreading / is_python_min) so this matrix does not collide. | ||
| force_ignore_keys: | ||
| - python | ||
| - numpy | ||
| - is_freethreading | ||
| - is_python_min | ||
|
Comment on lines
+23
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have a question about this: given my experiments and the need for |
||
|
|
||
| requirements: | ||
| run_constrained: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these were originally added to help with PBP generation, has something improved on the PBP side such that we can remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was needed a long time ago, but now it's already in a global cbc.yaml. It was a bug on PBP. I don't recall when it was fixes