refactor(lockscreen): Refactor UserLogin and enhance macOS aesthetic#85
Merged
Conversation
Issue: - Unhandled 'Permissions check failed' runtime error crashes dev server on fullscreen load. - Undesired AM/PM string visible in Lock screen clock. - Lock screen login UI was cluttered, used rectangular buttons, and lacked macOS authentic details like hints and click-away dismissal. Root-cause: - Fullscreen API requires a user gesture; programmatic calls return rejected promises which crashed the React dev server overlay. - `toLocaleTimeString` was defaulting to 12-hour format in some locales. - Chakra UI `Button` base styles conflicted with custom hover transforms, breaking the visual macOS aesthetic for the user avatar. Fix: - Catch rejected promises from the fullscreen API. - Explicitly enforce 24-hour format (`hour12: false`) for the lock screen clock. - Replace Chakra UI `Button` components with plain `Box` elements to achieve pure CSS circular avatars, stacked text layouts, and ring-glow hover animations. Changes: - App.tsx: Handle fullscreen promise rejection to fix permission errors. - TimeDate.tsx: Force 24-hour time format removing AM/PM. - DateTime.selector.ts: Refactor timeInAmPm to use native Intl API instead of lodash. - UserLogin.tsx: - Extract subcomponents (UserAvatarButton, PasswordInput, HintPopover). - Adopt macOS-style circular avatar with hover ring. - Add translucent hint popover next to password input. - Add background click-away overlay. - locales: Add password hint translation keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Root-cause:
toLocaleTimeStringwas defaulting to 12-hour format in some locales.Buttonbase styles conflicted with custom hover transforms, breaking the visual macOS aesthetic for the user avatar.Fix:
hour12: false) for the lock screen clock.Buttoncomponents with plainBoxelements to achieve pure CSS circular avatars, stacked text layouts, and ring-glow hover animations.Changes: