Repository navigation
ci: run deploy-integration only for installer changes - #695
Merged
Merged
Conversation
The ~5 min/image Docker cluster job ran on every push to main and on PRs touching anything under deploy/** (Caddy, Helm, k8s), package.json (every dependency bump), any workflow, or the unit-level installer tests. Narrow the PR filter to the shipped installer files (install.sh, uninstall.sh, lib/, http_handlers.xml), tests/deploy/, and ci.yml, and drop the push-to-main trigger (release tags and manual dispatch still run it; images are pinned, so an unchanged installer cannot drift). Unit-level installer tests stay in the `test` job. Refs #692 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P3CopPwrpzeWAJd7vaaLSk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker cluster integration job (
deploy-integration, ~5 min × 2 images) was running far more often than needed:main;deploy/**(Caddy, Helm, k8s,config.json.example),package.json(every Dependabot bump), any workflow file, or the unit-level installer tests/helpers.Now it runs only when the installer itself can be affected:
deploy/install.sh,deploy/uninstall.sh,deploy/lib/**,deploy/http_handlers.xml,tests/deploy/**,.github/workflows/ci.ymlsrc/**, HTML/CSS/JS,package.json, Caddy/Helm/k8s, other workflowstests/unit/*-script.test.js/tests/helpers/deploy-*testjob)mainworkflow_dispatchThe image tags are pinned exactly, so an unchanged installer can't drift between runs; no nightly run is added. A skipped job counts as a pass in the CI gate (same as before). The wiki deployment page now documents this.
This PR edits
ci.yml, so the job runs once on it, as expected.Refs #692
🤖 Generated with Claude Code
https://claude.ai/code/session_01P3CopPwrpzeWAJd7vaaLSk