Skip to content

Improve The Sunken Crypt's graphics: warm light, props and motion - #3

Merged
samkeen merged 1 commit into
mainfrom
claude/godot-graphics-pass
Sep 29, 2026
Merged

samkeen merged 1 commit into
mainfrom
claude/godot-graphics-pass

Conversation

@samkeen

@samkeen samkeen commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

The room painter now lights with warm firelight and cool daylight: where
fire dominates, stone, floor and wood swap to warm twins of their ramps
with a dithered edge. Seams and the floor under props are shaded, the
ceiling has ribs carried down the walls as pilasters, side passages show
depth, and the rooms gain banners, weapon racks, a crate, an altar with
carvings, rubble lit by daylight, open treasure chests and glowing
skeleton eyes. Dithering is gentler so flat areas read cleaner.

In the game, demo/room_fx.gd flickers pixels in the painter's flame ramp,
raises embers from the brightest flame pixels, and dissolves between rooms
in Bayer order. Framed panels get brass corner pieces, and the menu title
an outline over the brighter backdrop.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01YEf4Qot4HstXVdXff3c9if

The room painter now lights with warm firelight and cool daylight: where
fire dominates, stone, floor and wood swap to warm twins of their ramps
with a dithered edge. Seams and the floor under props are shaded, the
ceiling has ribs carried down the walls as pilasters, side passages show
depth, and the rooms gain banners, weapon racks, a crate, an altar with
carvings, rubble lit by daylight, open treasure chests and glowing
skeleton eyes. Dithering is gentler so flat areas read cleaner.

In the game, demo/room_fx.gd flickers pixels in the painter's flame ramp,
raises embers from the brightest flame pixels, and dissolves between rooms
in Bayer order. Framed panels get brass corner pieces, and the menu title
an outline over the brighter backdrop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YEf4Qot4HstXVdXff3c9if
@samkeen
samkeen merged commit 1e39b3e into main Sep 29, 2026
4 of 5 checks passed
@samkeen
samkeen deleted the claude/godot-graphics-pass branch September 29, 2026 13:44
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: eabc5d5e-9533-4bda-85cf-d5338fbc6543

📥 Commits

Reviewing files that changed from the base of the PR and between 9546873 and f9cad78.

⛔ Files ignored due to path filters (8)
  • godot-jev/demo/art/antechamber.png is excluded by !**/*.png
  • godot-jev/demo/art/armory.png is excluded by !**/*.png
  • godot-jev/demo/art/hall.png is excluded by !**/*.png
  • godot-jev/demo/art/hall_cleared.png is excluded by !**/*.png
  • godot-jev/demo/art/ossuary.png is excluded by !**/*.png
  • godot-jev/demo/art/stairs.png is excluded by !**/*.png
  • godot-jev/demo/art/vault.png is excluded by !**/*.png
  • godot-jev/docs/screenshot.png is excluded by !**/*.png
📒 Files selected for processing (10)
  • godot-jev/README.md
  • godot-jev/demo/adventure.gd
  • godot-jev/demo/room_fx.gd
  • godot-jev/demo/room_fx.gd.uid
  • godot-jev/demo/start_menu.gd
  • godot-jev/demo/style.gd
  • godot-jev/tests/run_tests.gd
  • godot-jev/tests/test_room_fx.gd
  • godot-jev/tests/test_room_fx.gd.uid
  • godot-jev/tools/paint_rooms.gd
 ________________________________________
< CI is red. I'm also red. We match now. >
 ----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants