Repository navigation
CI: drop the PHP 7.4 lint now that preprod runs 8.4.27 - #160
Merged
Merged
Conversation
The PHP job ran on 7.4 and 8.4 while preprod kept PHP 7.4 after prod had switched. Both environments now run 8.4.27, so 7.4 no longer guards any runtime: the job goes back to a single 8.4 run, and the docs stop asking for 7.4-compatible code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
Follow-up of #158 / #159. While prod ran PHP 8.4.27 and preprod still 7.4, the PHP lint/test job ran on a
['7.4', '8.4']matrix so that no change could break preprod's runtime. Since Altered-Re-Union/AlteredOps#21, both environments run PHP 8.4.27 (checked onX-Powered-Byfor altered.re and website-preprod.altered.re), so the 7.4 leg no longer protects anything.What changes
plugins-ci.yml: the "PHP lint and plugin PHP tests" job goes back to a single 8.4 run, under its original name. The jobs thatneeds:it use its id (php), which is unchanged, and the aggregatedPlugins CIcheck still covers it.CONTRIBUTING.md,README.md,design-system/AGENTS.md: stop asking for PHP 7.4-compatible code. PHP 8 syntax is fine; keep new code free of 8.5-only features.No PHP code changes.
Notes
maingets these doc changes with the next preprod → main sync. Until then its CONTRIBUTING still mentions the 7.4 lint on preprod.🤖 Generated with Claude Code