Repository navigation
fix: include cost_relation in full Meilisearch documents - #81
Merged
Merged
Conversation
cost_relation was only computed by partial updates (--fields), so a full re-index (addDocuments replaces whole documents) silently dropped it and the costRelation filter stopped matching until --fields=cost_relation ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
cost_relation(equal/mainHigher/recallHigher) n'était calculé que par la mise à jour partielle (--fields=cost_relationou champs d'effets).hydrate()ne l'ajoutait pas au document complet.Comme un index complet (ou
--set, ou la réindexation après import de gameplay format / patch de cartes) remplace les documents entiers dans Meilisearch, le champ disparaissait et le filtre surcost_relationne remontait plus ces cartes.Changement
hydrate()ajoutecost_relationvia le mêmecomputeCostRelation()que le mode partiel.Tests
cost_relationphp bin/phpunit --testsuite Unit→ OK (34 tests)cost_relation,card_type,set_date,main_cost) identiques aux documents complets, 0 différenceAprès déploiement
Rien d'obligatoire. Les cartes réindexées depuis un index complet /
--setsanscost_relationpeuvent être rattrapées avec :🤖 Generated with Claude Code