Repository navigation
Conversation
…i-field priority Consolidate the three separate order filters (OrderFilter, SetDateOrderFilter, CardGroupOrderFilter) into a single CardOrderFilter that processes order[...] params in the order the client sent them, instead of filter-registration order. Also adds support for order[reference] and order[name.<lang>], previously silently ignored. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was
linked to
issues
Aug 26, 2026
gjuillot
force-pushed
the
fix/card-order-filter
branch
from
August 27, 2026 21:10
294c436 to
ea70287
Compare
…rch path The Card ordering logic is duplicated across two backends: CardOrderFilter (pure Doctrine) and SearchAwareCollectionProvider's ORDER_MAP (Meilisearch). Fixing only the former left the bug in place for any request that also uses a Meilisearch-mapped filter (rarity, set.reference, faction.code, ...) — which is most real-world traffic, including the original bug report's own repro requests. Add reference/name_fr/name_en to MeilisearchService::SORTABLE_ATTRIBUTES and to SearchAwareCollectionProvider::ORDER_MAP so Meilisearch can sort/paginate on these fields too, instead of silently ignoring them. Note: the live Meilisearch index still needs `app:meilisearch:index --configure` re-run after deploy to pick up the new sortable attributes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate the three separate order filters (OrderFilter, SetDateOrderFilter, CardGroupOrderFilter) into a single CardOrderFilter that processes order[...] params in the order the client sent them, instead of filter-registration order. Also adds support for order[reference] and order[name.], previously silently ignored.
Remaining work / known limitations
1. Ops step required after deploy. The live Meilisearch index needs
app:meilisearch:index --configurere-run to pick up the newsortableAttributes(reference,name_fr,name_en). Until that runs, requests usingorder[reference]ororder[name.<lang>]combined with a Meilisearch-mapped filter (rarity, set.reference, faction.code, ...) will have Meilisearch reject the sort request; the code catches that and falls back to the (already-fixed) Doctrine path, so results stay correct — just slower until the index is reconfigured.2.
it/es/deare not sortable via Meilisearch. Onlyname_frandname_enexist in the Meilisearch index (MeilisearchService::SEARCHABLE_ATTRIBUTES); the other three locales aren't indexed as separate fields at all. The pure-Doctrine path (CardOrderFilter) can already sort by any locale viaCardGroupTranslation, but as soon as a request also includes a Meilisearch-mapped filter, onlyfr/ensort correctly —it/es/dewould still be silently ignored. Fixing this fully means addingname_it/name_es/name_deto the Meilisearch document schema,SEARCHABLE_ATTRIBUTES/SORTABLE_ATTRIBUTES, andSearchAwareCollectionProvider::ORDER_MAP— not done here.Fixes
Altered-Community/community-feedback#75
Altered-Community/community-feedback#64
Altered-Community/community-feedback#50