Skip to content

fix: incorrect lickspout position - #47

Merged
arjunsridhar12345 merged 7 commits into
devfrom
22-incorrect-lickspout-position
Jul 28, 2026
Merged

fix: incorrect lickspout position#47
arjunsridhar12345 merged 7 commits into
devfrom
22-incorrect-lickspout-position

Conversation

@arjunsridhar12345

@arjunsridhar12345 arjunsridhar12345 commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Attempts to fix #22 and #43.

UPDATE: This seems to be showing changes. @micahwoodard does this seem like it's kind of working?

Session used for plot: 864253_2026-07-17_19-28-27

image

@arjunsridhar12345
arjunsridhar12345 marked this pull request as ready for review July 27, 2026 23:17
"cannot derive lickspout position."
)
# Resolution enum names encode the divisor (MICROSTEP8 -> 8); the
# enum *value* (0..3) does not, so parse from the name.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh that's kinda weird

@micahwoodard

Copy link
Copy Markdown

@arjunsridhar12345 yes, I think this look right to me. Looking at the data, bias interventions were given as follows

  1. water left, trial 269, timestamp 2061521.266784
  2. water left, trial 283, timestamp 2061624.5968
  3. water left, trial 296, timestamp 2061696.9368
  4. water left, trial 308, timestamp 2061800.1608
  5. move left, trial 599, timestamp: 2063840.482784
  6. water left, trial 611, timestamp 2063916.8768
  7. water left, trial 623, timestamp 2063984.138784
  8. water left, trial 635, timestamp 2064069.3088
  9. water left, trial 647, timestamp 2064155.2488

The intervention were following the spec

"bias_intervention_parameters": {
        "threshold": {
          "upper": 0.7,
          "lower": 0.3
        },
        "intervention_interval": 10,
        "maximum_water_corrections": 5,
        "bias_window_length": 200,
        "lickspout_offset_delta": 0.05
      },

@arjunsridhar12345
arjunsridhar12345 merged commit 8cfb5a5 into dev Jul 28, 2026
3 checks passed
@arjunsridhar12345
arjunsridhar12345 deleted the 22-incorrect-lickspout-position branch July 28, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants