Repository navigation
Pass container options to docker steps (ID-5345) - #48
Merged
Merged
Conversation
kdumontnu
requested review from
MarcusSmith and
allspice-bgraham
and
a balanced review from Copilot
August 31, 2026 17:57
There was a problem hiding this comment.
Pull request overview
Passes operator-configured container options to docker:// step containers.
Changes:
- Propagates
ContainerOptionsto Docker steps. - Tests exact option forwarding.
- Verifies allowlisted read-only mounts survive sanitization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pkg/runner/step_docker.go |
Passes container options to Docker steps. |
pkg/runner/step_docker_test.go |
Tests option propagation. |
pkg/container/docker_run_test.go |
Tests mount merging and sanitization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jadidbourbaki
approved these changes
Aug 31, 2026
jadidbourbaki
left a comment
jadidbourbaki
left a comment
There was a problem hiding this comment.
Simple clean well-scoped addition for something that probably should have been an option in the first place. LGTM.
| assert.Nil(t, err) | ||
|
|
||
| assert.Equal(t, "node:14", input.Image) | ||
| assert.Equal(t, sd.RunContext.Config.ContainerOptions, input.Options) |
| Privileged: rc.Config.Privileged, | ||
| UsernsMode: rc.Config.UsernsMode, | ||
| Platform: rc.Config.ContainerArchitecture, | ||
| Options: rc.Config.ContainerOptions, |
jhdoak
approved these changes
Aug 31, 2026
kdumontnu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container.optionstodocker://step containers--mountsurvives production option merging and volume sanitizationTesting
go test ./pkg/runner -run "^(TestStepDockerMain|TestStepDockerPrePost)$" -count=1go test ./pkg/container -run "^(TestCheckVolumes|TestOptionsMountSurvivesSanitize)$" -count=1go vet ./pkg/runner ./pkg/containergo build ./...Rollout validation
Before release, run the staging instance-verification workflow and confirm the CA is visible and TLS succeeds inside the
docker://step.Closes Notion ticket ID-5345.