Skip to content

chore(deps): sync common-c mic and wire new sources - #173

Merged
qiin2333 merged 1 commit into
masterfrom
codex/sync-commonc-mic
Nov 6, 2026
Merged

qiin2333 merged 1 commit into
masterfrom
codex/sync-commonc-mic

Conversation

@qiin2333

@qiin2333 qiin2333 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

改了啥呀

  • 把 moonlight-common-c 子模块从 31a2a45 同步到 mic 分支最新提交 4c26259。
  • 将 common-c 新增的 MAT live playback、Pyrowave HDR、Recorder 实现加入 HarmonyOS native CMake target。

为啥要改

common-c 更新后,源码虽然能编译,但链接阶段找不到新增实现,导致 HAP 构建失败。现在这些源文件会随 moonlight_nativelib 一起构建,坏掉的链接状态被修好了喵。

验证

  • DEVECO_SDK_HOME=/Applications/DevEco-Studio.app/Contents/sdk
  • JAVA_HOME=/Applications/DevEco-Studio.app/Contents/jbr/Contents/Home
  • /Applications/DevEco-Studio.app/Contents/tools/hvigor/bin/hvigorw assembleHap --mode module -p product=default
  • 结果:BUILD SUCCESSFUL
  • 现有 ArkTS 权限、NAPI 模块校验提示和未配置签名提示仍为 warning。

Summary by CodeRabbit

  • 功能更新
    • 共享库现已支持更多媒体接收与播放能力,并包含录制相关支持。

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

No actionable comments were generated in the recent review.

Walkthrough

更新 moonlight-common-c 子模块引用,并将 MAT、Pyrowave 和录制回调相关源文件加入 MOONLIGHT_COMMON_SOURCES。

Changes: 共享库源文件

Layer / File(s) Summary
更新子模块并注册源文件
nativelib/src/main/cpp/moonlight-common-c, nativelib/src/main/cpp/CMakeLists.txt
子模块引用更新至新提交。MOONLIGHT_COMMON_SOURCES 新增 MAT 解包、实时播放与接收、Pyrowave 协议与重组,以及录制回调源文件。

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to c498f

The new shared-library sources are registered in the native target. No material merge-blocking issue was established.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 标题准确概括了同步 common-c mic 分支和将新源文件加入构建的主要变更。
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c03e1e4 and 1f7d089.

Files selected for processing: 2

  • nativelib/src/main/cpp/CMakeLists.txt
  • nativelib/src/main/cpp/moonlight-common-c

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@qiin2333
qiin2333 force-pushed the codex/sync-commonc-mic branch from 1f7d089 to c498fd1 Compare November 6, 2026 11:08
@qiin2333
qiin2333 merged commit ef1e7df into master Nov 6, 2026
2 of 3 checks passed
@qiin2333
qiin2333 deleted the codex/sync-commonc-mic branch November 6, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant