Fail the build on any checkstyle violation

AGENTS.md

@@ -300,8 +300,15 @@ Hand-written sources are Google Java Style, 2-space indent, 100-column width. Fo
 enforced by running `googleJavaFormat(...)` directly from root `build.gradle`'s Spotless block (no
 separate Spotless config file); linting is `config/checkstyle/checkstyle.xml`, derived from
 checkstyle's own bundled `google_checks.xml` with deviations documented in a comment at the top of
-that file. The generated jextract bindings under `jmlx-ffi/src/main/generated/java` are exempt from
-both and must stay byte-identical to `scripts/regen-bindings.sh`'s output — never hand-edit them.
+that file. Checkstyle runs with `maxWarnings = 0` in both builds: the config reports violations at
+`warning` severity, but any violation fails `check` (for `buildSrc`, run
+`./gradlew -p buildSrc check`; see below), the same as a Spotless difference. Fix a violation
+(rename, add the Javadoc) rather than leaving it. Never raise `maxWarnings`. Use a targeted
+suppression (`@SuppressWarnings("checkstyle:<Check>")` or a
+`// CHECKSTYLE.SUPPRESS: <Check> for +N lines` comment) only where a name is genuinely externally
+constrained, with a comment saying why. The generated jextract bindings under
+`jmlx-ffi/src/main/generated/java` are exempt from both and must stay byte-identical to
+`scripts/regen-bindings.sh`'s output — never hand-edit them.
 `buildSrc` (shared Gradle build-logic helpers, e.g. `PublishedPomDependencies`) is its own isolated
 Gradle build, so root `build.gradle`'s `subprojects{}` conventions never reach it -- it applies the
 same checkstyle/Spotless configuration independently in its own `buildSrc/build.gradle` instead

README.md

@@ -70,7 +70,7 @@ on a virtual thread is rejected.
 
 ## Code style
 
-Hand-written sources are Google Java Style with 2-space indentation and a 100-column width, enforced by running `google-java-format` directly via Spotless (see `build.gradle`'s `spotless` block and `config/checkstyle/checkstyle.xml`, which derives from Google's own upstream artifact; see its comments for the one remaining documented deviation). The generated jextract bindings under `jmlx-ffi/src/main/generated/java` are exempt from both, since they must stay byte-identical to `scripts/regen-bindings.sh`'s output.
+Hand-written sources are Google Java Style with 2-space indentation and a 100-column width, enforced by running `google-java-format` directly via Spotless (see `build.gradle`'s `spotless` block and `config/checkstyle/checkstyle.xml`, which derives from Google's own upstream artifact; see its comments for the one remaining documented deviation). Any checkstyle violation fails `check` (`maxWarnings = 0`), even though the config reports it at `warning` severity. The generated jextract bindings under `jmlx-ffi/src/main/generated/java` are exempt from both, since they must stay byte-identical to `scripts/regen-bindings.sh`'s output.
 
 ```sh
 ./gradlew spotlessCheck   # verify formatting

build.gradle

@@ -784,6 +784,10 @@ subprojects {
     checkstyle {
         toolVersion = checkstyleVersion
         configFile = rootProject.file('config/checkstyle/checkstyle.xml')
+        // The config's severity is 'warning', and Gradle's default maxWarnings is unlimited, so
+        // without this a violation only prints a [WARN] line and check still passes. Zero
+        // tolerance makes every checkstyle violation fail check, just like spotlessCheck.
+        maxWarnings = 0
     }
 
     // jmlx-ffi/src/main/generated/java is committed jextract output, not

buildSrc/build.gradle

@@ -41,6 +41,8 @@ test {
 checkstyle {
     toolVersion = '13.10.0'
     configFile = file('../config/checkstyle/checkstyle.xml')
+    // Same zero-tolerance policy as the main build's subprojects block.
+    maxWarnings = 0
 }
 
 spotless {

jmlx-tokenizer/src/test/java/se/alipsa/jmlx/tokenizer/HfTokenizerTest.java

@@ -347,7 +347,7 @@ void additionalDefaultTemplateBeatsTheLegacyProcessorChatTemplateFile() throws E
   }
 
   @Test
-  void aBundleWithoutAnyTemplateSourceStillHasNoTemplates() throws Exception {
+  void bundleWithoutAnyTemplateSourceStillHasNoTemplates() throws Exception {
     Path directory = Files.createDirectory(temporaryDirectory.resolve("no-templates"));
     Files.copy(wordPieceFixture(), directory.resolve("tokenizer.json"));
     HfTokenizer tokenizer = HfTokenizer.fromDirectory(directory);
@@ -360,7 +360,7 @@ void aBundleWithoutAnyTemplateSourceStillHasNoTemplates() throws Exception {
   }
 
   @Test
-  void aMalformedLegacyChatTemplateFileIsRejected() throws Exception {
+  void malformedLegacyChatTemplateFileIsRejected() throws Exception {
     Path missingKey = Files.createDirectory(temporaryDirectory.resolve("legacy-missing-key"));
     Files.copy(wordPieceFixture(), missingKey.resolve("tokenizer.json"));
     Files.writeString(missingKey.resolve("chat_template.json"), "{\"other\": \"nope\"}");

jmlx-vision/src/main/java/se/alipsa/jmlx/vision/ImageDecoder.java

@@ -844,9 +844,9 @@ private static void pngChunk(byte[] b, int pos, int length, boolean preIdat, Png
     } else if (cid == 0x74455874) { // "tEXt"
       pngTextChunk(b, data, length, info);
     } else if (cid == 0x7A545874) { // "zTXt"
-      pngZTxtChunk(b, data, length, info);
+      pngZtxtChunk(b, data, length, info);
     } else if (cid == 0x69545874) { // "iTXt"
-      pngITxtChunk(b, data, length, info);
+      pngItxtChunk(b, data, length, info);
     }
   }
 
@@ -860,15 +860,15 @@ private static void pngChunk(byte[] b, int pos, int length, boolean preIdat, Png
   private static void pngTextChunk(byte[] b, int data, int length, PngInfo info) {
     int end = data + length;
     int nul = indexOfByte(b, data, end);
-    int kEnd = nul >= 0 ? nul : end;
-    int vStart = nul >= 0 ? nul + 1 : end;
-    if (kEnd == data) {
+    int keyEnd = nul >= 0 ? nul : end;
+    int valueStart = nul >= 0 ? nul + 1 : end;
+    if (keyEnd == data) {
       return;
     }
-    if (equalsRegion(b, data, kEnd - data, EXIF_TEXT_KEYWORD)) {
-      info.exifPayload = Arrays.copyOfRange(b, vStart, end);
-    } else if (equalsRegion(b, data, kEnd - data, XMP_TEXT_KEYWORD)) {
-      info.xmpText = Arrays.copyOfRange(b, vStart, end);
+    if (equalsRegion(b, data, keyEnd - data, EXIF_TEXT_KEYWORD)) {
+      info.exifPayload = Arrays.copyOfRange(b, valueStart, end);
+    } else if (equalsRegion(b, data, keyEnd - data, XMP_TEXT_KEYWORD)) {
+      info.xmpText = Arrays.copyOfRange(b, valueStart, end);
     }
   }
 
@@ -878,12 +878,12 @@ private static void pngTextChunk(byte[] b, int data, int length, PngInfo info) {
    * incomplete zlib payload yields the reference's empty value, which is stored (the slot is set,
    * to a falsy value), like the reference's {@code v = b""} on {@code zlib.error}.
    */
-  private static void pngZTxtChunk(byte[] b, int data, int length, PngInfo info) {
+  private static void pngZtxtChunk(byte[] b, int data, int length, PngInfo info) {
     int end = data + length;
     int nul = indexOfByte(b, data, end);
-    int kEnd = nul >= 0 ? nul : end;
+    int keyEnd = nul >= 0 ? nul : end;
     int restStart = nul >= 0 ? nul + 1 : end;
-    if (kEnd == data) {
+    if (keyEnd == data) {
       return;
     }
     if (restStart < end && (b[restStart] & 0xFF) != 0) {
@@ -893,9 +893,9 @@ private static void pngZTxtChunk(byte[] b, int data, int length, PngInfo info) {
     if (value == null) {
       value = new byte[0];
     }
-    if (equalsRegion(b, data, kEnd - data, EXIF_TEXT_KEYWORD)) {
+    if (equalsRegion(b, data, keyEnd - data, EXIF_TEXT_KEYWORD)) {
       info.exifPayload = value;
-    } else if (equalsRegion(b, data, kEnd - data, XMP_TEXT_KEYWORD)) {
+    } else if (equalsRegion(b, data, keyEnd - data, XMP_TEXT_KEYWORD)) {
       info.xmpText = value;
     }
   }
@@ -910,7 +910,7 @@ private static void pngZTxtChunk(byte[] b, int data, int length, PngInfo info) {
    * ({@code cf} 1) must use comp method 0, and any inflate failure leaves the slots untouched, like
    * the reference's early returns.
    */
-  private static void pngITxtChunk(byte[] b, int data, int length, PngInfo info) {
+  private static void pngItxtChunk(byte[] b, int data, int length, PngInfo info) {
     int end = data + length;
     int nul1 = indexOfByte(b, data, end);
     if (nul1 < 0) {
@@ -931,8 +931,8 @@ private static void pngITxtChunk(byte[] b, int data, int length, PngInfo info) {
     if (tkEnd < 0) {
       return;
     }
-    int vStart = tkEnd + 1;
-    byte[] value = Arrays.copyOfRange(b, vStart, end);
+    int valueStart = tkEnd + 1;
+    byte[] value = Arrays.copyOfRange(b, valueStart, end);
     if (cf != 0) {
       if (cm != 0) {
         return;

jmlx-vision/src/main/java/se/alipsa/jmlx/vision/SmolVlmGeometryPlan.java

@@ -25,6 +25,7 @@
 public record SmolVlmGeometryPlan(
     int stage1Height, int stage1Width, int stage2Height, int stage2Width, int rows, int cols) {
 
+  /** Validates that the component values are mutually consistent (see the record Javadoc). */
   public SmolVlmGeometryPlan {
     if (stage1Height <= 0 || stage1Width <= 0) {
       throw new IllegalArgumentException(

jmlx-vision/src/test/java/se/alipsa/jmlx/vision/ImageDecoderTest.java

@@ -154,7 +154,7 @@ void iccProfileAndExifDoNotChangeDecodedPixels() throws Exception {
   }
 
   @Test
-  void tRnsOnTruecolorAndGrayscaleDecodesAsOpaque() throws Exception {
+  void trnsOnTruecolorAndGrayscaleDecodesAsOpaque() throws Exception {
     // A tRNS chunk on truecolor/grayscale is ignored (the reference keeps mode RGB/L and its
     // RGB conversion drops the transparency): each twin decodes byte-identical to its opaque
     // counterpart.
@@ -169,7 +169,7 @@ void tRnsOnTruecolorAndGrayscaleDecodesAsOpaque() throws Exception {
   }
 
   @Test
-  void tRnsOnPalettedPngDecodesAsOpaqueTwin() throws Exception {
+  void trnsOnPalettedPngDecodesAsOpaqueTwin() throws Exception {
     // Palette tRNS is dropped to match the pinned processor (its palette is rebuilt from
     // getpalette(), RGB only): each tRNS twin decodes byte-identical to its opaque counterpart.
     Path fixtures = OracleFixtures.fixtures();