Repository navigation
chore(deps): 🔧 move benchmark-only dependencies to a bench group - #53
Merged
Merged
Conversation
cyclopts is used only by the scripts under benches/, so it moves from dev to a new bench group, which also declares the quimb and scipy the scripts import. cmaes stays in the test group with a comment: quimb's cotengra warns without it, and filterwarnings = ["error"] turns that into a test failure. Closes #12 Assisted-by: pi:claude-opus-5.5
Contributor
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Closes #12.
Scope after the changes merged since the issue
Most of #12 is already done on
main:numbaandllvmliteare gone.quimbmoved to thetestgroup in refactor!: 🔥 drop quimb as a runtime dependency #24.numpyandopt_einsum.This PR covers the rest:
cycloptsmoves fromdevto a newbenchgroup. The group also declares thequimbandscipythat the benchmark scripts import.devincludesbench, souv sync --all-groupsworks as before.cmaesstays in thetestgroup, with a comment explaining why. Nothing imports it directly, but without it cotengra (pulled in by quimb) raises aUserWarningwhen it plans a contraction.filterwarnings = ["error"]then fails the suite; I checked this by removing it. So it can't be dropped, but it was never a runtime dependency.benches/README.mdexplains how to install the group.uv.lockis regenerated.Checks
uv run prek run --all-filesis clean.uv run pytest -m "not slow": 123 passed, 1 skipped (no CuPy).bench_mpo_mpo.pyruns end to end on a small problem, andbench_depth.py --helpworks.