Skip to content

test(ftp): verify no FTP connection on import or initialization #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luabida merged 1 commit into from
Aug 14, 2026
Merged

test(ftp): verify no FTP connection on import or initialization #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pysus/tests/api/ftp/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,24 @@ def simulate_retrlines(cmd, callback):

mock_ftp_internal.cwd.assert_called_once_with("/test/path")
mock_ftp_internal.retrlines.assert_called_once()


def test_ftp_init_does_not_connect():
"""Verify that instantiating FTP does not open an FTP connection."""
with patch("pysus.api.ftp.client.FTPLib") as mock_ftplib:
client = FTP()
assert client.ftp is None
mock_ftplib.assert_not_called()


def test_import_does_not_connect_ftp():
"""Verify importing pysus modules does not connect to FTP server."""
with patch("ftplib.FTP") as mock_ftplib:
import pysus # noqa: F401
import pysus.api # noqa: F401
import pysus.api.ftp # noqa: F401
from pysus.api.client import PySUS

pysus_instance = PySUS()
assert pysus_instance._ftp is None
mock_ftplib.assert_not_called()
Loading