refactor: remove archived tweet field from historical alerts - #19
Open
esloch wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the archived
tweetfield from the historical alert records handled by AlertTools.This change is part of the cleanup required before removing the physical
tweetcolumn from the historical alert tables in AlertaDengue.Changes
tweetfromtabela_historico()output;tweetinwrite_alerta();casoscli$tweet <- NAplaceholder;Validation
git diff --checkpasses;R/alert_functions.Rhas no activetweetreferences;tweet;Notes
The full old
testthat::test_dir("tests/testthat")suite still fails in pre-existing tests because some package functions are not loaded in the test environment:setCriteria,getCases,epiYear, anddata2SE.The new focused test file passes independently.
Out of scope