Repository navigation
Surface provider error details and make verifier temperature configurable - #145
Merged
Merged
Conversation
Surface provider error details and make verifier temperature configurable
|
🚀 Thanks for opening a Pull Request! A maintainer will review this soon. Meanwhile: Your contribution helps make this project better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to cross-platform console output, workflow configuration, and error handling. The most significant changes are the introduction of robust handling for terminal encodings (especially on Windows), improved test coverage for console output, and minor enhancements to workflow and configuration files.
Console output improvements:
Updated the
Consoleclass insrc/coderrr/ui/console.pyto automatically detect when the output stream cannot encode certain Unicode glyphs (such as on legacy Windows consoles). It now falls back to an ASCII icon set and ensures that unencodable model-generated text is gracefully degraded instead of raising exceptions. Supporting helper functions and logic were added for this detection and fallback. [1] [2] [3] [4]Added a comprehensive test suite in
tests/test_console.pyto verify icon selection, encoding detection, and that console output does not crash on streams with limited encoding support. These tests cover both decision logic and integration scenarios across platforms.Workflow and configuration updates:
Refined the GitHub Actions workflow in
.github/workflows/v2.yml:Added a
temperatureparameter to the verifier configuration insrc/coderrr/config.pyand used it insrc/coderrr/verify.pyto make verification less brittle to deterministic false negatives. [1] [2]Error handling improvements:
src/coderrr/llm/anthropic.py,src/coderrr/llm/google.py,src/coderrr/llm/openai_compat.py) to ensure that empty exception messages are replaced with the exception class name, preventing uninformative output. [1] [2] [3]Documentation:
CLAUDE.mdto clarify git usage restrictions and the plan-first workflow for contributors.