Skip to content

Add platform-specific landing page downloads#2605

Merged
illegalcall merged 6 commits into
mainfrom
agent/platform-downloads-navbar
Jul 13, 2026
Merged

Add platform-specific landing page downloads#2605
illegalcall merged 6 commits into
mainfrom
agent/platform-downloads-navbar

Conversation

@codebanditssss

@codebanditssss codebanditssss commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace the landing-page install CTA with direct, platform-specific desktop downloads sourced from the documented latest-release assets
  • provide architecture choices for macOS and a full desktop platform chooser for mobile and tablet visitors
  • remove the navbar install button, tighten the navbar layout, and keep the primary navigation geometrically centered
  • add GitHub to the navbar's social links
image

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

React Doctor found 9 issues in 2 files · 9 warnings · score 67 / 100 (Needs work) · vs main

9 warnings

components/LandingHero.tsx

  • ⚠️ L347 Large component is hard to read and change no-giant-component
  • ⚠️ L912 Label missing associated control label-has-associated-control
  • ⚠️ L975 Label missing associated control label-has-associated-control
  • ⚠️ L990 Label missing associated control label-has-associated-control
  • ⚠️ L1012 Label missing associated control label-has-associated-control
  • ⚠️ L1036 Label missing associated control label-has-associated-control
  • ⚠️ L1038 Control missing accessible label control-has-associated-label
  • ⚠️ L1081 Data fetching inside an effect no-fetch-in-effect

components/LandingNav.tsx

  • ⚠️ L132 Plain anchor reloads internal Next.js links nextjs-no-a-element
⚠️ Warning: .github/workflows/react-doctor.yml is configured incorrectly. See below to fix.

React Doctor compares against main to report only the issues this pull request introduces. This run couldn't complete that comparison (usually a shallow CI checkout with no merge base), so it listed every issue in the changed files, including ones that already existed on main.

Add fetch-depth: 0 to the actions/checkout step in .github/workflows/react-doctor.yml so the checkout includes the history React Doctor needs:

 jobs:
   react-doctor:
     steps:
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

       - uses: millionco/react-doctor@v2

To silence this warning, set silence-missing-baseline-warning: true on the React Doctor action.

Reviewed by React Doctor for commit 1dd29eb. See inline comments for fixes.

@codebanditssss codebanditssss marked this pull request as ready for review July 11, 2026 12:20

@illegalcall illegalcall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the CTA device-selection behavior.

Browser validation shows a Linux desktop receives the direct AppImage at 1440px but is redirected to the installation guide at 1024px; an iPhone profile also receives only the guide. This conflicts with the PR description, which promises direct desktop downloads and a full desktop chooser for mobile/tablet visitors.

This PR also introduces platform detection, resize-driven routing, and four download targets without regression tests. Please add focused coverage for Windows, Linux, both macOS choices, mobile/tablet, and a narrow desktop viewport.

Comment thread frontend/src/landing/components/LandingHero.tsx Outdated
Comment thread frontend/src/landing/components/LandingHero.tsx Outdated
Comment thread frontend/src/landing/components/LandingHero.tsx Outdated
Comment thread frontend/src/landing/components/LandingHero.tsx Outdated
@i-trytoohard

Copy link
Copy Markdown
Contributor

From the NotesBot call on 2026-07-12, this existing pr appears to be relevant.
Match confidence: 0.69 (fuzzy).

Relevant discussion excerpts:

    • Iterate landing page per prateek feedback (CTA color dulling, spacing/alignment fixes, dark theme color adjustments). - Coordinate with Kiki and reuse content from existing page/live mockups (Kushy/Kushi). - Add download page improvements: docs/FAQs button, remove “legacy npm CLI” from landing flow, ensure [...]
    • Coordinate with Kiki and reuse content from existing page/live mockups (Kushy/Kushi). - Add download page improvements: docs/FAQs button, remove “legacy npm CLI” from landing flow, ensure GitHub-driven dynamic release data. - Continue PR to open terminal-clicked links in preview box (not external browser).
    • Add download page improvements: docs/FAQs button, remove “legacy npm CLI” from landing flow, ensure GitHub-driven dynamic release data. - Continue PR to open terminal-clicked links in preview box (not external browser).

Source thread: https://discord.com/channels/1476302178913357958/1525926468444749957/1525926468444749957

Generated by AO Bot based on the transcript from NotesBot.

Comment thread frontend/src/landing/components/LandingHero.tsx
Comment thread frontend/src/landing/components/LandingNav.tsx
@illegalcall illegalcall merged commit cf8ad8b into main Jul 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants